[I] Allow for - in Glue Catalog DB/Table names [iceberg]

2023-11-27 Thread via GitHub
spatel-nex opened a new issue, #9169: URL: https://github.com/apache/iceberg/issues/9169 ### Feature Request / Improvement I want to be able to use - in my table name in Glue but unable to because there are table validations set that only allow the _ character ### Query engine

Re: [PR] Core: Add a util to read and write partition stats [iceberg]

2023-11-27 Thread via GitHub
ajantha-bhat closed pull request #8503: Core: Add a util to read and write partition stats URL: https://github.com/apache/iceberg/pull/8503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Core: Move `iceberg-parquet` files to `iceberg-core` [iceberg]

2023-11-27 Thread via GitHub
ajantha-bhat closed pull request #8500: Core: Move `iceberg-parquet` files to `iceberg-core` URL: https://github.com/apache/iceberg/pull/8500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Core: Move `iceberg-parquet` files to `iceberg-core` [iceberg]

2023-11-27 Thread via GitHub
ajantha-bhat commented on PR #8500: URL: https://github.com/apache/iceberg/pull/8500#issuecomment-1829224667 Going with alternative approach of writing stats from `iceberg-data` module and engines calling that. Core API will not write stats. -- This is an automated message from the Ap

[I] flink programs sometimes fail to write to icebergTable. The.avro file in metadata cannot be found [iceberg]

2023-11-27 Thread via GitHub
lpy148145 opened a new issue, #9168: URL: https://github.com/apache/iceberg/issues/9168 ### Apache Iceberg version 1.2.1 ### Query engine Flink ### Please describe the bug 🐞 2023-11-28 14:11:07,576 INFO org.apache.flink.runtime.executiongraph.ExecutionGrap

Re: [I] Discussion: Replace usage of `Builder` with `TypedBuilder` [iceberg-rust]

2023-11-27 Thread via GitHub
xiaoyang-sde commented on issue #88: URL: https://github.com/apache/iceberg-rust/issues/88#issuecomment-1829169593 Hi! I'm learning Apache Iceberg and I think this issue might be a good starting point to learn about the source code. I noticed that `PartitionSpec`, `Snapshot`, and `SortOrd

Re: [PR] test: Add integration tests for rest catalog. [iceberg-rust]

2023-11-27 Thread via GitHub
liurenjie1024 commented on PR #109: URL: https://github.com/apache/iceberg-rust/pull/109#issuecomment-1829137007 cc @Fokko @Xuanwo @ZENOTME @JanKaul PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] why should we use file.createOrOverwrite to create a datafile or manifest file? [iceberg]

2023-11-27 Thread via GitHub
singhpk234 commented on issue #9100: URL: https://github.com/apache/iceberg/issues/9100#issuecomment-1829071104 There was a fix for this in pipeline to fail fast when we have conflicting file names in the pr : - https://github.com/apache/iceberg/pull/6839 One logical explanation a

[PR] test: Add integration tests for rest catalog. [iceberg-rust]

2023-11-27 Thread via GitHub
liurenjie1024 opened a new pull request, #109: URL: https://github.com/apache/iceberg-rust/pull/109 Close #100 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Flink: Read parquet BINARY column as String for expected [iceberg]

2023-11-27 Thread via GitHub
RussellSpitzer commented on PR #8808: URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1829023255 It still feels like we are adding a special workaround to Iceberg for something which shouldn't be happening in the first place. Can you explain the use case again? Why can't the

[I] encountered a problem while making multiple bucket maybe a bug [iceberg]

2023-11-27 Thread via GitHub
madeirak opened a new issue, #9167: URL: https://github.com/apache/iceberg/issues/9167 ### Apache Iceberg version None ### Query engine Spark ### Please describe the bug 🐞 I have encountered a problem showing as below First adding 2 buckets to a table for

Re: [PR] Flink: Read parquet BINARY column as String for expected [iceberg]

2023-11-27 Thread via GitHub
Apache9 commented on PR #8808: URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1828987729 > > Anyway, the conversion is based on the fact that the user defines the column as string and wants to use it as a string. If you think there is an inappropriate scenario, could you give

Re: [I] Create JUnit5-version of TableTestBase [iceberg]

2023-11-27 Thread via GitHub
lisirrx commented on issue #9073: URL: https://github.com/apache/iceberg/issues/9073#issuecomment-1828921848 > @lisirrx yes we first need to have a JUnit5-version of `TableTestBase` (`TestBase` should be fine as a name) before we can convert any other tests that depend on this class. >

[PR] Build: Bump aiohttp from 3.8.6 to 3.9.0 [iceberg-python]

2023-11-27 Thread via GitHub
dependabot[bot] opened a new pull request, #168: URL: https://github.com/apache/iceberg-python/pull/168 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.6 to 3.9.0. Release notes Sourced from https://github.com/aio-libs/aiohttp/releases";>aiohttp's releases. 3.9

Re: [PR] Use Strings to verify null and empty string [iceberg]

2023-11-27 Thread via GitHub
RussellSpitzer commented on PR #9090: URL: https://github.com/apache/iceberg/pull/9090#issuecomment-1828877268 Thanks @ndrluis for the PR, Thank you @nastra and @Fokko for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Replace `.length() > 0` with `!.isEmpty()` [iceberg]

2023-11-27 Thread via GitHub
RussellSpitzer closed issue #9088: Replace `.length() > 0` with `!.isEmpty()` URL: https://github.com/apache/iceberg/issues/9088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Use Strings to verify null and empty string [iceberg]

2023-11-27 Thread via GitHub
RussellSpitzer merged PR #9090: URL: https://github.com/apache/iceberg/pull/9090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [I] Support Delete & Update iceberg table with Flink [iceberg]

2023-11-27 Thread via GitHub
github-actions[bot] commented on issue #7311: URL: https://github.com/apache/iceberg/issues/7311#issuecomment-1828847271 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] TestMetricsRowGroupFilterTypes fails on certain machines, bisects to ORC lib upgrade [iceberg]

2023-11-27 Thread via GitHub
github-actions[bot] commented on issue #7303: URL: https://github.com/apache/iceberg/issues/7303#issuecomment-1828847304 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] DataFile creation by file path seems wrong [iceberg]

2023-11-27 Thread via GitHub
github-actions[bot] commented on issue #7612: URL: https://github.com/apache/iceberg/issues/7612#issuecomment-1828847207 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

[PR] Build: Bump cython from 3.0.5 to 3.0.6 [iceberg-python]

2023-11-27 Thread via GitHub
dependabot[bot] opened a new pull request, #167: URL: https://github.com/apache/iceberg-python/pull/167 Bumps [cython](https://github.com/cython/cython) from 3.0.5 to 3.0.6. Changelog Sourced from https://github.com/cython/cython/blob/master/CHANGES.rst";>cython's changelog.

[PR] Build: Bump mkdocs-material from 9.4.12 to 9.4.14 [iceberg-python]

2023-11-27 Thread via GitHub
dependabot[bot] opened a new pull request, #166: URL: https://github.com/apache/iceberg-python/pull/166 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.4.12 to 9.4.14. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk

[PR] Core: Remove deprecated code in DeleteFileIndex [iceberg]

2023-11-27 Thread via GitHub
aokolnychyi opened a new pull request, #9166: URL: https://github.com/apache/iceberg/pull/9166 This PR removes deprecated and no longer used code in `DeleteFileIndex`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-11-27 Thread via GitHub
aokolnychyi opened a new pull request, #9165: URL: https://github.com/apache/iceberg/pull/9165 This PR refactors `DeleteFileIndexBenchmark`: - Add `FileGenerationUtil` to be used in metadata benchmarks. - Use `FileGenerationUtil` to generate files to speed up the initialization pha

Re: [I] show table extended not supported for v2 table. [iceberg]

2023-11-27 Thread via GitHub
lsabreu96 commented on issue #5782: URL: https://github.com/apache/iceberg/issues/5782#issuecomment-1828511599 Not sure if the error's stem is the same, but I'm facing the same behaviour when using AWS Glue as metastore -- This is an automated message from the Apache Git Service. To respo

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

2023-11-27 Thread via GitHub
amogh-jahagirdar commented on PR #9134: URL: https://github.com/apache/iceberg/pull/9134#issuecomment-1828471872 Merging, thanks for the reviews @nastra @rakesh-das08 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

2023-11-27 Thread via GitHub
amogh-jahagirdar merged PR #9134: URL: https://github.com/apache/iceberg/pull/9134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

2023-11-27 Thread via GitHub
amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1406602865 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,41 @@ public UpdateSnapshotReferencesOperation replaceBran

Re: [PR] Flink: Read parquet BINARY column as String for expected [iceberg]

2023-11-27 Thread via GitHub
RussellSpitzer commented on PR #8808: URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1828351888 > > Anyway, the conversion is based on the fact that the user defines the column as string and wants to use it as a string. If you think there is an inappropriate scenario, cou

Re: [I] Create JUnit5-version of TableTestBase [iceberg]

2023-11-27 Thread via GitHub
nastra commented on issue #9073: URL: https://github.com/apache/iceberg/issues/9073#issuecomment-1828294714 @lisirrx yes we first need to have a JUnit5-version of `TableTestBase` (`TestBase` should be fine as a name) before we can convert any other tests that depend on this class. To

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

2023-11-27 Thread via GitHub
nastra commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1406496932 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,41 @@ public UpdateSnapshotReferencesOperation replaceBranch(String

Re: [I] iceberg-mr: Switch tests to JUnit5 + AssertJ-style assertions [iceberg]

2023-11-27 Thread via GitHub
nastra commented on issue #9083: URL: https://github.com/apache/iceberg/issues/9083#issuecomment-1828283598 @lschetanrao sure that would be great. Just go ahead and open a PR with the proper changes. You might want to look into git history of how other modules have been migrated to JUnit5 +

[I] Cannot delete files cleanly with CatalogUtil::dropTableData [iceberg]

2023-11-27 Thread via GitHub
caohoangha126 opened a new issue, #9164: URL: https://github.com/apache/iceberg/issues/9164 ### Apache Iceberg version 1.4.0 ### Query engine None ### Please describe the bug 🐞 I am using the [CatalogUtil::dropTableData](https://sourcegraph.com/github.com/a

Re: [I] Is there a roadmap? [iceberg-go]

2023-11-27 Thread via GitHub
lovromazgon closed issue #24: Is there a roadmap? URL: https://github.com/apache/iceberg-go/issues/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

Re: [I] Is there a roadmap? [iceberg-go]

2023-11-27 Thread via GitHub
zeroshade commented on issue #24: URL: https://github.com/apache/iceberg-go/issues/24#issuecomment-1828140798 Roadmap has been added to the README, so this can be closed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1406301821 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inte

Re: [PR] Hive: Refactor TestHiveCatalog tests to use the core CatalogTests [iceberg]

2023-11-27 Thread via GitHub
nk1506 commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1406295533 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [I] Cannot alter map key [iceberg]

2023-11-27 Thread via GitHub
caican00 commented on issue #9163: URL: https://github.com/apache/iceberg/issues/9163#issuecomment-1827833388 gently ping @rdblue Could you help me with that? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[I] Cannot alter map key [iceberg]

2023-11-27 Thread via GitHub
caican00 opened a new issue, #9163: URL: https://github.com/apache/iceberg/issues/9163 ### Apache Iceberg version 1.4.0 ### Query engine Spark ### Please describe the bug 🐞 Hi, I wanted to update the datatype of map key in a iceberg table, but I g

Re: [I] iceberg-mr: Switch tests to JUnit5 + AssertJ-style assertions [iceberg]

2023-11-27 Thread via GitHub
lschetanrao commented on issue #9083: URL: https://github.com/apache/iceberg/issues/9083#issuecomment-1827731984 Hi @nastra, I am new to contributing in open source but I would like to try this if you don't mind. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Flink: Backport #9078 to v1.16 and v1.15 [iceberg]

2023-11-27 Thread via GitHub
pvary commented on PR #9151: URL: https://github.com/apache/iceberg/pull/9151#issuecomment-1827633516 > Hi @pvary, thanks for the review. Just to clarify, is this PR consider clean backport? If you just have to apply the Flink v1.17 changes to the v1.16, v1.15 folder, and you do not

Re: [PR] Flink: Backport #9078 to v1.16 and v1.15 [iceberg]

2023-11-27 Thread via GitHub
cgpoh commented on PR #9151: URL: https://github.com/apache/iceberg/pull/9151#issuecomment-1827584534 Hi @pvary, thanks for the review. Just to clarify, is this PR consider clean backport? I will try my best to move the junit 4 tests to 5 😃 -- This is an automated message from the

Re: [PR] Flink: Backport #9078 to v1.16 and v1.15 [iceberg]

2023-11-27 Thread via GitHub
pvary commented on PR #9151: URL: https://github.com/apache/iceberg/pull/9151#issuecomment-1827544350 Thanks for the backports @cgpoh! Please when doing backport next time, tell the reviewers if it was a clean backport, or you had to change anything. This would help with the reviews!

Re: [PR] Flink: Backport #9078 to v1.16 and v1.15 [iceberg]

2023-11-27 Thread via GitHub
pvary merged PR #9151: URL: https://github.com/apache/iceberg/pull/9151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Hive: Refactor TestHiveCatalog tests to use the core CatalogTests [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1405931381 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from, TableIdentifier originalT

Re: [PR] Flink: Backport #8553 to v1.15, v1.16 [iceberg]

2023-11-27 Thread via GitHub
pvary commented on PR #9139: URL: https://github.com/apache/iceberg/pull/9139#issuecomment-1827525105 > @pvary I meant separate to multiple back port PRs. one PR for one purpose. it is easier to review too. Thanks! -- This is an automated message from the Apache Git Service. To res

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405921702 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405920842 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405918571 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405917923 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405915025 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405912896 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405911776 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405861868 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalogUtil.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405869289 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -186,6 +190,10 @@ protected void doCommit(TableMetadata base, TableMetadata metad

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405868486 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -186,6 +190,10 @@ protected void doCommit(TableMetadata base, TableMetadata metad

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405867723 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inter

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405866442 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inter

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405865265 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalogUtil.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405861868 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalogUtil.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405856390 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalogUtil.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405850906 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405850906 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405838600 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405834655 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405833787 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405831314 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -234,15 +225,25 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2023-11-27 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1405826355 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -264,6 +265,163 @@ public void renameTable(TableIdentifier from, TableIdentifier original