Re: [PR] Partition Evolution [iceberg-python]

2023-12-29 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1438454615 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else sna

Re: [PR] Partition Evolution [iceberg-python]

2023-12-29 Thread via GitHub
amogh-jahagirdar commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1438454375 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else sna

Re: [I] Spark: Data file rewriting spark job fails with oom [iceberg]

2023-12-29 Thread via GitHub
github-actions[bot] closed issue #6956: Spark: Data file rewriting spark job fails with oom URL: https://github.com/apache/iceberg/issues/6956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] Spark: Data file rewriting spark job fails with oom [iceberg]

2023-12-29 Thread via GitHub
github-actions[bot] commented on issue #6956: URL: https://github.com/apache/iceberg/issues/6956#issuecomment-1872400046 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438388233 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -164,21 +163,22 @@ public void testHistory() { Iterator sn

Re: [PR] Partition Evolution [iceberg-python]

2023-12-29 Thread via GitHub
amogh-jahagirdar commented on PR #245: URL: https://github.com/apache/iceberg-python/pull/245#issuecomment-1872255962 There's still a lot of cleanup required, and need to add unit tests, also some bugs I'm encountering. But I'm putting up this draft since the core pieces are here. -- Thi

Re: [PR] Remove `publish:` section from `.asf.yaml` [iceberg-rust]

2023-12-29 Thread via GitHub
amogh-jahagirdar merged PR #141: URL: https://github.com/apache/iceberg-rust/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[PR] Partition Evolution [iceberg-python]

2023-12-29 Thread via GitHub
amogh-jahagirdar opened a new pull request, #245: URL: https://github.com/apache/iceberg-python/pull/245 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] Remove `publish:` section from `.asf.yaml` [iceberg-rust]

2023-12-29 Thread via GitHub
Fokko opened a new pull request, #141: URL: https://github.com/apache/iceberg-rust/pull/141 We don't specify this in `iceberg-python` either. I got this in my inbox: ![image](https://github.com/apache/iceberg-rust/assets/1134248/d68c332f-4958-47a1-b1bf-b394d1d94108) -- T

Re: [I] doc: Update README with roadmap and feature status. [iceberg-rust]

2023-12-29 Thread via GitHub
Fokko closed issue #133: doc: Update README with roadmap and feature status. URL: https://github.com/apache/iceberg-rust/issues/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] feat: Add roadmap and features status in README.md [iceberg-rust]

2023-12-29 Thread via GitHub
Fokko merged PR #134: URL: https://github.com/apache/iceberg-rust/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] feat: Add roadmap and features status in README.md [iceberg-rust]

2023-12-29 Thread via GitHub
Fokko commented on code in PR #134: URL: https://github.com/apache/iceberg-rust/pull/134#discussion_r1438291922 ## README.md: ## @@ -21,6 +21,77 @@ Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/). +## RoadMap Review Comment: ```suggestion

Re: [PR] chore: Upgrade toolchain to 1.75.0 [iceberg-rust]

2023-12-29 Thread via GitHub
Fokko merged PR #140: URL: https://github.com/apache/iceberg-rust/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Add ManifestWrite benchmark [iceberg]

2023-12-29 Thread via GitHub
Fokko commented on code in PR #8637: URL: https://github.com/apache/iceberg/pull/8637#discussion_r1438282292 ## core/src/jmh/java/org/apache/iceberg/ManifestWriteBenchmark.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core: Add KLL Datasketch and Hive ColumnStatisticsObj as standard blo… [iceberg]

2023-12-29 Thread via GitHub
bitsondatadev commented on PR #8202: URL: https://github.com/apache/iceberg/pull/8202#issuecomment-1872122843 @findepi @danielcweeks could one of you PTAL this? Don't want this effort to get lost. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438242984 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -189,32 +189,32 @@ public void testManifests() { for (int

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438241867 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -318,51 +318,50 @@ public void testUnPartitionedTable() throws

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438237702 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -523,67 +499,65 @@ public void testAlterTableModifyColumnPosition() {

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438236120 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438235397 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -523,67 +499,65 @@ public void testAlterTableModifyColumnPosition() {

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438231519 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
vinitpatni commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438229566 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(

Re: [PR] Spark: Add actions for disaster recovery. [iceberg]

2023-12-29 Thread via GitHub
laithalzyoud commented on PR #4705: URL: https://github.com/apache/iceberg/pull/4705#issuecomment-1871994719 Hello @flyrain @rdblue , are there any plans to file separate PRs and merge into master? We are already using these changes in a [forked version](https://github.com/revolut-engineeri

Re: [PR] Core, Data, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-29 Thread via GitHub
zhongyujiang commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1438129707 ## core/src/main/java/org/apache/iceberg/TableProperties.java: ## @@ -334,6 +335,9 @@ private TableProperties() {} public static final String MAX_REF_AGE_MS = "

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-29 Thread via GitHub
nastra merged PR #9367: URL: https://github.com/apache/iceberg/pull/9367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438122352 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -318,51 +318,50 @@ public void testUnPartitionedTable() throws IOEx

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438121453 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -189,32 +189,32 @@ public void testManifests() { for (int i =

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438121453 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -189,32 +189,32 @@ public void testManifests() { for (int i =

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438121270 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java: ## @@ -164,21 +163,22 @@ public void testHistory() { Iterator snapsh

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438120202 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -523,67 +499,65 @@ public void testAlterTableModifyColumnPosition() {

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438120090 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -523,67 +499,65 @@ public void testAlterTableModifyColumnPosition() {

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438119892 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -523,67 +499,65 @@ public void testAlterTableModifyColumnPosition() {

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438119232 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438119069 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(

Re: [PR] Adding Junit 5 conversion and AssertJ style for TestFlinkCatalogTable… [iceberg]

2023-12-29 Thread via GitHub
nastra commented on code in PR #9381: URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438118700 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java: ## @@ -94,84 +89,77 @@ public void testGetTable() { new Schema(