Re: [PR] Remove `record_fields` from the `Record` class [iceberg-python]

2024-05-30 Thread via GitHub
HonahX merged PR #580: URL: https://github.com/apache/iceberg-python/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

[I] Support for loading different hive-metastore versions at Runtime [iceberg]

2024-05-30 Thread via GitHub
liuj84 opened a new issue, #10401: URL: https://github.com/apache/iceberg/issues/10401 ### Feature Request / Improvement Iceberg does not support loading different versions of hive-metastore jars at runtime. According to the [Spark SQL documentation](https://spark.apache.org/docs/lat

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on PR #10397: URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138839436 If we don't intend to make `RESTMetricsReporter` public, then we can just remove the javadoc link on "Metrics Reporting" page. -- This is an automated message from the Apache Git Se

[PR] [Ruff] Enforce double quotes [iceberg-python]

2024-05-30 Thread via GitHub
HonahX opened a new pull request, #781: URL: https://github.com/apache/iceberg-python/pull/781 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Support CreateTableTransaction for HiveCatalog [iceberg-python]

2024-05-30 Thread via GitHub
HonahX commented on code in PR #683: URL: https://github.com/apache/iceberg-python/pull/683#discussion_r1620130553 ## tests/integration/test_writes/test_writes.py: ## @@ -609,17 +610,18 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None @py

Re: [PR] Support CreateTableTransaction for HiveCatalog [iceberg-python]

2024-05-30 Thread via GitHub
HonahX commented on code in PR #683: URL: https://github.com/apache/iceberg-python/pull/683#discussion_r1620130553 ## tests/integration/test_writes/test_writes.py: ## @@ -609,17 +610,18 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None @py

Re: [I] How to set Spark conf to use Parquet and Iceberg tables using glue catalog without catalog name(spark_catalog)? [iceberg]

2024-05-30 Thread via GitHub
sivakanthavel-tigeranalytics commented on issue #7748: URL: https://github.com/apache/iceberg/issues/7748#issuecomment-2138872010 Hello, I am using org.apache.iceberg.spark.SparkSessionCatalog instead of SparkCatalog. I am able to create both Iceberg and non-Iceberg tables on the Glu

Re: [I] SparkSessionCatalog with JDBC catalog: SHOW TABLES IN ... returns error but table exists in JDBC catalog [iceberg]

2024-05-30 Thread via GitHub
sivakanthavel-tigeranalytics commented on issue #10003: URL: https://github.com/apache/iceberg/issues/10003#issuecomment-2138905817 Hello @matepek @ajantha-bhat , Need some suggestions ! I am using org.apache.iceberg.spark.SparkSessionCatalog instead of SparkCatalog. I am able

[PR] replaced `i32` in `TableUpdate::SetDefaultSortOrder` to `i64` [iceberg-rust]

2024-05-30 Thread via GitHub
rwwwx opened a new pull request, #387: URL: https://github.com/apache/iceberg-rust/pull/387 Replaced `i32` in `TableUpdate::SetDefaultSortOrder` to `i64` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Cannot create table if location/endpoint is s3 on a "secure" Minio server [iceberg-python]

2024-05-30 Thread via GitHub
MongoExpUser commented on issue #540: URL: https://github.com/apache/iceberg-python/issues/540#issuecomment-2138944779 @thinkORo , **I was having the same issue. The following snippets solved the problem:** ``` catalog: default: "s3.endpoint": f"https://s3.{r

Re: [PR] Docs: Add archive for documentations older than 1.4.0 [iceberg]

2024-05-30 Thread via GitHub
Fokko merged PR #10374: URL: https://github.com/apache/iceberg/pull/10374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Spark Action to Analyze table [iceberg]

2024-05-30 Thread via GitHub
rice668 commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1620254074 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Spark Action to Analyze table [iceberg]

2024-05-30 Thread via GitHub
rice668 commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1620254074 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10397: URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139030717 The `RESTCatalog.html` is there on the `asf-site` branch: https://github.com/apache/iceberg/blob/asf-site/javadoc/1.5.2/org/apache/iceberg/rest/RESTCatalog.html -- This is an automated

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10397: URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139028210 @manuzhang I think that would make more sense, but I would love to get @nastra input here (he's currently on holiday). -- This is an automated message from the Apache Git Service. To re

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10397: URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139034146 The correct url is: https://iceberg.apache.org/javadoc/1.5.2/org/apache/iceberg/rest/RESTCatalog.html. Looks like the paths are not correct -- This is an automated message from the Apa

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10397: URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139053254 The URL in the `metrics-reporting.md` does look similar to the URLs that are working, so probably it is failing because the class is not in the Javadoc. Thanks again for reporting this @m

Re: [I] Javadoc issues [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on issue #10378: URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2139084041 > https://iceberg.apache.org/javadoc/nightly is not found It looks like the nightly points to latest according to https://github.com/apache/iceberg/tree/main/site#building-the-

Re: [PR] [Build] Add a script to execute revapi without gradle plugin [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on code in PR #10386: URL: https://github.com/apache/iceberg/pull/10386#discussion_r1620292410 ## build.gradle: ## @@ -139,35 +137,6 @@ subprojects { apply plugin: 'java-library' - if (project.name in REVAPI_PROJECTS) { -apply plugin: 'com.palantir.re

Re: [I] Javadoc issues [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on issue #10378: URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2139099462 > It looks like the nightly points to latest according to https://github.com/apache/iceberg/tree/main/site#building-the-versioned-docs It's documented but not actually implemen

Re: [PR] Core: Make RESTMetricsReporter public [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on code in PR #10397: URL: https://github.com/apache/iceberg/pull/10397#discussion_r1620309427 ## core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java: ## @@ -26,7 +26,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -class RESTMe

[PR] Fix `ADLSFileIO.listPrefix()` behavior [iceberg]

2024-05-30 Thread via GitHub
snazy opened a new pull request, #10403: URL: https://github.com/apache/iceberg/pull/10403 Unlike all other FileIO implementations of `listPrefix()`, the `ADLSFileIO` only returns the path without a leading `/`. This change fixes this inconsistent behavior. For example, S3, GCS and H

Re: [PR] Fix `ADLSFileIO.listPrefix()` behavior [iceberg]

2024-05-30 Thread via GitHub
adutra commented on code in PR #10403: URL: https://github.com/apache/iceberg/pull/10403#discussion_r1620352582 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSLocation.java: ## @@ -82,4 +85,9 @@ public Optional container() { public String path() { return path

Re: [PR] Incremental Append Scan [iceberg-python]

2024-05-30 Thread via GitHub
chinmay-bhat commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1620353853 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: r

Re: [PR] Incremental Append Scan [iceberg-python]

2024-05-30 Thread via GitHub
chinmay-bhat commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1620357567 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: r

Re: [PR] Incremental Append Scan [iceberg-python]

2024-05-30 Thread via GitHub
chinmay-bhat commented on code in PR #533: URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1620353853 ## pyiceberg/table/__init__.py: ## @@ -1754,6 +1788,134 @@ def to_arrow(self) -> pa.Table: def to_pandas(self, **kwargs: Any) -> pd.DataFrame: r

Re: [I] MERGE INTO TABLE is not supported temporarily [iceberg]

2024-05-30 Thread via GitHub
rakesh-tmdc commented on issue #5424: URL: https://github.com/apache/iceberg/issues/5424#issuecomment-2139259265 > I am also facing similar kind of issue with merge into functionality. spark 3.2 + iceberg 0.13.1: > > spark-sql: merge into `spark_catalog`.`default`.`merge_test` as t us

[PR] Incremental Changelog Scan [iceberg-python]

2024-05-30 Thread via GitHub
chinmay-bhat opened a new pull request, #782: URL: https://github.com/apache/iceberg-python/pull/782 Draft PR. Depends on incremental append scan #533 - [x] Tests (test output has both Insert and Delete operations) I created a new class ChangelogScanTask(ScanTask) to store chan

Re: [I] Javadoc issues [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on issue #10378: URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2139574447 > Links in https://iceberg.apache.org/docs/1.4.3/metrics-reporting points to 1.5.2 Javadoc That one is quite tricky. It looks like it uses the macro plugin to set the version.

Re: [PR] [Ruff] Enforce double quotes [iceberg-python]

2024-05-30 Thread via GitHub
Fokko merged PR #781: URL: https://github.com/apache/iceberg-python/pull/781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Support CreateTableTransaction for HiveCatalog [iceberg-python]

2024-05-30 Thread via GitHub
Fokko commented on code in PR #683: URL: https://github.com/apache/iceberg-python/pull/683#discussion_r1620751827 ## tests/integration/test_writes/test_writes.py: ## @@ -609,17 +610,18 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None @pyt

Re: [PR] fix: make PrimitiveLiteral and Literal not be Ord [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on code in PR #386: URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1620764612 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -118,6 +118,15 @@ impl Type { matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_)) } +

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2139649747 > I believe we should enable the storage we want in `iceberg` crate. Will this cause the library to include unnecessary dependencies? I think using features to control

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2139653246 BTW how the integration tests passed when s3 is not included? I think at least [this test](https://github.com/apache/iceberg-rust/blob/048eac801f09ca58e610a020db2e29bd95c22d

Re: [PR] replaced `i32` in `TableUpdate::SetDefaultSortOrder` to `i64` [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 merged PR #387: URL: https://github.com/apache/iceberg-rust/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Docs: Point links in metrics-reporting.md to GitHub Java source [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on code in PR #10397: URL: https://github.com/apache/iceberg/pull/10397#discussion_r1620844093 ## core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java: ## @@ -26,7 +26,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -class RE

Re: [PR] fix: make PrimitiveLiteral and Literal not be Ord [iceberg-rust]

2024-05-30 Thread via GitHub
ZENOTME commented on code in PR #386: URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1620852535 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -118,6 +118,15 @@ impl Type { matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_)) } +//

Re: [PR] Build: Remove links checker [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2139851200 @Fokko we need to remove the config file as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Docs: Ignore link-checking for Apache mailing list and GNU website [iceberg]

2024-05-30 Thread via GitHub
manuzhang closed pull request #10388: Docs: Ignore link-checking for Apache mailing list and GNU website URL: https://github.com/apache/iceberg/pull/10388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Docs: Ignore link-checking for Apache mailing list and GNU website [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on PR #10388: URL: https://github.com/apache/iceberg/pull/10388#issuecomment-2139857195 Superseded by #10404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Flink 1.19: Fix flaky TestIcebergSourceFailover > testBoundedWithSavepoint [iceberg]

2024-05-30 Thread via GitHub
stevenzwu commented on code in PR #10393: URL: https://github.com/apache/iceberg/pull/10393#discussion_r1620956381 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java: ## @@ -333,28 +336,28 @@ private static void restartTaskManager(R

Re: [PR] Flink 1.19: Fix flaky TestIcebergSourceFailover > testBoundedWithSavepoint [iceberg]

2024-05-30 Thread via GitHub
pvary commented on PR #10393: URL: https://github.com/apache/iceberg/pull/10393#issuecomment-2139996501 Thanks for the report @manuzhang and @stevenzwu, @manuzhang for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Flink 1.19: Fix flaky TestIcebergSourceFailover > testBoundedWithSavepoint [iceberg]

2024-05-30 Thread via GitHub
pvary merged PR #10393: URL: https://github.com/apache/iceberg/pull/10393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [I] Flaky Test `TestIcebergSourceFailover > testBoundedWithSavepoint` [iceberg]

2024-05-30 Thread via GitHub
pvary closed issue #10356: Flaky Test `TestIcebergSourceFailover > testBoundedWithSavepoint` URL: https://github.com/apache/iceberg/issues/10356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Build: Remove links checker [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2140004759 @manuzhang I was thinking of leaving in the link checker, but just removing it from the CI for now. You could still run it locally: https://github.com/apache/iceberg/tree/main/site#valida

Re: [PR] Test GitHub actions rate limit [iceberg]

2024-05-30 Thread via GitHub
manuzhang closed pull request #10400: Test GitHub actions rate limit URL: https://github.com/apache/iceberg/pull/10400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] AWS: Retain Glue Catalog column comment after updating Iceberg table [iceberg]

2024-05-30 Thread via GitHub
lawofcycles commented on code in PR #10276: URL: https://github.com/apache/iceberg/pull/10276#discussion_r1621143428 ## aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java: ## @@ -234,8 +258,26 @@ static void setTableInputInformation( Optional.ofNull

Re: [PR] docs: deploy on changes in `docs/` [iceberg]

2024-05-30 Thread via GitHub
Fokko merged PR #10394: URL: https://github.com/apache/iceberg/pull/10394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [I] ORC file format support [iceberg-python]

2024-05-30 Thread via GitHub
MehulBatra commented on issue #20: URL: https://github.com/apache/iceberg-python/issues/20#issuecomment-2140721883 I would like to take a shot at it @Fokko @HonahX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Parquet: page skipping using filtered row groups (vectorized and non-vectorized read) [iceberg]

2024-05-30 Thread via GitHub
wypoon commented on PR #10399: URL: https://github.com/apache/iceberg/pull/10399#issuecomment-2140776180 @rdblue @aokolnychyi @flyrain can you please review? I plan to do some performance testing later and will update with findings. @sunchao you may be interested in this too. The change

Re: [PR] Kafka Connect: Commit coordination [iceberg]

2024-05-30 Thread via GitHub
fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1621333676 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

2024-05-30 Thread via GitHub
fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1621377408 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

2024-05-30 Thread via GitHub
stevenzwu commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1621389662 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

2024-05-30 Thread via GitHub
stevenzwu commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1621395230 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Parquet: page skipping using filtered row groups (vectorized and non-vectorized read) [iceberg]

2024-05-30 Thread via GitHub
wypoon commented on PR #10399: URL: https://github.com/apache/iceberg/pull/10399#issuecomment-2140815049 For reference, the files that changed between https://github.com/apache/iceberg/pull/10228 and this PR are: arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrow

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

2024-05-30 Thread via GitHub
stevenzwu commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1621389662 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundati

[PR] Bump moto from 5.0.8 to 5.0.9 [iceberg-python]

2024-05-30 Thread via GitHub
dependabot[bot] opened a new pull request, #783: URL: https://github.com/apache/iceberg-python/pull/783 Bumps [moto](https://github.com/getmoto/moto) from 5.0.8 to 5.0.9. Changelog Sourced from https://github.com/getmoto/moto/blob/master/CHANGELOG.md";>moto's changelog. 5.0.

Re: [PR] Introduces the new IcebergSink based on the new V2 Flink Sink Abstraction [iceberg]

2024-05-30 Thread via GitHub
rodmeneses commented on code in PR #10179: URL: https://github.com/apache/iceberg/pull/10179#discussion_r1621550312 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/committer/SinkCommitter.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundat

Re: [I] I use the flinksource with filter conditions to read the iceberg table, which is unfiltered [iceberg]

2024-05-30 Thread via GitHub
owencwl closed issue #3068: I use the flinksource with filter conditions to read the iceberg table, which is unfiltered URL: https://github.com/apache/iceberg/issues/3068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] fix: make PrimitiveLiteral and Literal not be Ord [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on code in PR #386: URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1621647274 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -118,6 +118,15 @@ impl Type { matches!(self, Type::Struct(_) | Type::List(_) | Type::Map(_)) } +

Re: [I] How iceberg implements materialized views [iceberg]

2024-05-30 Thread via GitHub
smileyboy2019 commented on issue #10406: URL: https://github.com/apache/iceberg/issues/10406#issuecomment-2141177121 https://github.com/StarRocks/starrocks Refer to starrocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump moto from 5.0.8 to 5.0.9 [iceberg-python]

2024-05-30 Thread via GitHub
Fokko merged PR #783: URL: https://github.com/apache/iceberg-python/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-30 Thread via GitHub
HonahX commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1621822758 ## pyiceberg/table/__init__.py: ## @@ -277,6 +279,50 @@ def __init__(self, table: Table, autocommit: bool = False): self._autocommit = autocommit

Re: [PR] fix: make PrimitiveLiteral and Literal not be Ord [iceberg-rust]

2024-05-30 Thread via GitHub
marvinlanhenke commented on code in PR #386: URL: https://github.com/apache/iceberg-rust/pull/386#discussion_r1621824738 ## crates/iceberg/src/spec/values.rs: ## @@ -713,8 +866,117 @@ impl Datum { } } +/// Map is a collection of key-value pairs with a key type and a valu

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-30 Thread via GitHub
HonahX commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1621834384 ## tests/table/test_init.py: ## @@ -652,6 +652,58 @@ def test_update_metadata_add_snapshot(table_v2: Table) -> None: assert new_metadata.last_updated_ms == ne