liurenjie1024 merged PR #566:
URL: https://github.com/apache/iceberg-rust/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
ajantha-bhat commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722738419
##
data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ajantha-bhat commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722735848
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ajantha-bhat commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722723867
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ajantha-bhat commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722719791
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
manuzhang commented on code in PR #10952:
URL: https://github.com/apache/iceberg/pull/10952#discussion_r1722688458
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##
@@ -186,6 +186,8 @@ public void before() {
public void after() thro
wypoon commented on PR #10935:
URL: https://github.com/apache/iceberg/pull/10935#issuecomment-2297933397
@pvary I have added `testFlinkScenario1` and `testFlinkScenario2` to
`TestChangelogReader`. Please check the expected results. (I will rename the
tests later with more descriptive names.
wmoustafa commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issu
wmoustafa commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issu
wmoustafa commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issu
link3280 commented on issue #6196:
URL: https://github.com/apache/iceberg/issues/6196#issuecomment-2297901577
> > @singhpk234 is it worth documenting this so that it's clearer for users?
>
> Actually it took me a while to find this issue to confirm that Equality
deletes are not suppor
manuzhang commented on PR #10954:
URL: https://github.com/apache/iceberg/pull/10954#issuecomment-2297874007
@wypoon Thanks for creating this. It's been a while since I worked on #9888.
I will revisit it and go through your PR as well. Hopefully we can push this
feature for users this time.
liurenjie1024 merged PR #476:
URL: https://github.com/apache/iceberg-rust/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
stevenzwu commented on code in PR #10965:
URL: https://github.com/apache/iceberg/pull/10965#discussion_r1722564325
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestBase.java:
##
@@ -122,7 +123,23 @@ protected void assertSameElements(String message,
Iterable expec
karuppayya commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1722548584
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestComputeTableStatsAction.java:
##
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software F
sungwy commented on PR #1043:
URL: https://github.com/apache/iceberg-python/pull/1043#issuecomment-2297755108
> LGTM! I added a few comments. @Fokko @HonahX do you mind taking a look
when you get a chance?
Yes, would love to get your blessings on this refactoring @Fokko and @HonahX
-
sungwy commented on code in PR #1033:
URL: https://github.com/apache/iceberg-python/pull/1033#discussion_r1722545650
##
pyiceberg/catalog/rest.py:
##
@@ -532,7 +534,7 @@ def _config_headers(self, session: Session) -> None:
session.headers["Content-type"] = "application/
sungwy merged PR #1072:
URL: https://github.com/apache/iceberg-python/pull/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
sungwy merged PR #1075:
URL: https://github.com/apache/iceberg-python/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
sungwy merged PR #1077:
URL: https://github.com/apache/iceberg-python/pull/1077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
sungwy merged PR #1076:
URL: https://github.com/apache/iceberg-python/pull/1076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
github-actions[bot] commented on issue #5977:
URL: https://github.com/apache/iceberg/issues/5977#issuecomment-2297732147
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #5958:
URL: https://github.com/apache/iceberg/issues/5958#issuecomment-2297732114
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #5951:
URL: https://github.com/apache/iceberg/pull/5951#issuecomment-2297732073
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #5954:
URL: https://github.com/apache/iceberg/pull/5954#issuecomment-2297732091
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #5877:
URL: https://github.com/apache/iceberg/pull/5877#issuecomment-2297732001
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#issuecomment-2297732020
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] closed pull request #4941: Core: Use Table Partitioning
sort with manual Sort Order in Rewrite Data Files
URL: https://github.com/apache/iceberg/pull/4941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] closed issue #5958: Not able to process hundred of RowData
types
URL: https://github.com/apache/iceberg/issues/5958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #5959:
URL: https://github.com/apache/iceberg/pull/5959#issuecomment-2297732129
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on issue #5945:
URL: https://github.com/apache/iceberg/issues/5945#issuecomment-2297732055
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on PR #5942:
URL: https://github.com/apache/iceberg/pull/5942#issuecomment-2297732033
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on issue #5846:
URL: https://github.com/apache/iceberg/issues/5846#issuecomment-2297731988
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#issuecomment-2297731713
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
aokolnychyi commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722504135
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
aokolnychyi commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722501925
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
dependabot[bot] opened a new pull request, #1077:
URL: https://github.com/apache/iceberg-python/pull/1077
Bumps [moto](https://github.com/getmoto/moto) from 5.0.12 to 5.0.13.
Changelog
Sourced from https://github.com/getmoto/moto/blob/master/CHANGELOG.md";>moto's
changelog.
dependabot[bot] opened a new pull request, #1076:
URL: https://github.com/apache/iceberg-python/pull/1076
Bumps [griffe](https://github.com/mkdocstrings/griffe) from 1.0.0 to 1.1.0.
Release notes
Sourced from https://github.com/mkdocstrings/griffe/releases";>griffe's
releases.
aokolnychyi commented on code in PR #10846:
URL: https://github.com/apache/iceberg/pull/10846#discussion_r1722488735
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
aokolnychyi commented on code in PR #10846:
URL: https://github.com/apache/iceberg/pull/10846#discussion_r1722488735
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
dependabot[bot] opened a new pull request, #1075:
URL: https://github.com/apache/iceberg-python/pull/1075
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.31 to 9.5.32.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>
stevenzwu merged PR #10957:
URL: https://github.com/apache/iceberg/pull/10957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
jackye1995 commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1722436641
##
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##
@@ -194,15 +192,34 @@ public static String decodeString(String encoded) {
* @return UTF-8 encod
jackye1995 commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1722436641
##
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##
@@ -194,15 +192,34 @@ public static String decodeString(String encoded) {
* @return UTF-8 encod
amogh-jahagirdar commented on code in PR #10846:
URL: https://github.com/apache/iceberg/pull/10846#discussion_r1722391302
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
amogh-jahagirdar commented on code in PR #10846:
URL: https://github.com/apache/iceberg/pull/10846#discussion_r1722391302
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
stevenzwu merged PR #10859:
URL: https://github.com/apache/iceberg/pull/10859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
zeroshade commented on PR #130:
URL: https://github.com/apache/iceberg-go/pull/130#issuecomment-2297407754
CC @Fokko @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rdblue commented on PR #10948:
URL: https://github.com/apache/iceberg/pull/10948#issuecomment-2297312087
Thanks for reviewing, everyone. I've opened a thread on the dev list to
merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
sungwy opened a new issue, #1074:
URL: https://github.com/apache/iceberg-python/issues/1074
### Feature Request / Improvement
We'd like to support writes to Bucket partitioned tables by leveraging
pyiceberg_core package of iceberg-rust.
- [ ] Expose Bucket Transform through PyO3 on
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722260283
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
sungwy commented on PR #556:
URL: https://github.com/apache/iceberg-rust/pull/556#issuecomment-2297298410
Thank you for the reviews @Xuanwo - I've taken all of your feedback and
refactored the code to use the arrow::pyarrow crate
--
This is an automated message from the Apache Git Service
sdd commented on code in PR #476:
URL: https://github.com/apache/iceberg-rust/pull/476#discussion_r1722209176
##
crates/catalog/rest/src/catalog.rs:
##
@@ -504,8 +504,15 @@ impl Catalog for RestCatalog {
.query::(request)
.await?;
+let config
sungwy merged PR #1073:
URL: https://github.com/apache/iceberg-python/pull/1073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
sungwy opened a new pull request, #1073:
URL: https://github.com/apache/iceberg-python/pull/1073
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722175695
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722173257
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722169292
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722170737
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722169865
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
Xuanwo commented on code in PR #476:
URL: https://github.com/apache/iceberg-rust/pull/476#discussion_r1722149100
##
crates/catalog/rest/src/catalog.rs:
##
@@ -504,8 +504,15 @@ impl Catalog for RestCatalog {
.query::(request)
.await?;
+let conf
singhpk234 commented on issue #10156:
URL: https://github.com/apache/iceberg/issues/10156#issuecomment-2297093657
@cccs-jc no i wasn't i tried this unit test :
```
@TestTemplate
public void testResumingStreamReadFromCheckpointWithStreamFromTimestamp()
throws Exception {
Xuanwo merged PR #572:
URL: https://github.com/apache/iceberg-rust/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
stevenzwu commented on code in PR #10484:
URL: https://github.com/apache/iceberg/pull/10484#discussion_r1722057725
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/JdbcLockFactory.java:
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software
singhpk234 commented on PR #9362:
URL: https://github.com/apache/iceberg/pull/9362#issuecomment-2297005056
Thanks @amogh-jahagirdar really appreciate it ! No problem at all, can
totally understand !
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
amogh-jahagirdar merged PR #9362:
URL: https://github.com/apache/iceberg/pull/9362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
amogh-jahagirdar commented on PR #9362:
URL: https://github.com/apache/iceberg/pull/9362#issuecomment-2297000551
Sorry @singhpk234 that this somehow missed getting merged a long time ago! I
think we can just go ahead and merge.
--
This is an automated message from the Apache Git Service.
sungwy commented on code in PR #556:
URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1722066450
##
.github/workflows/bindings_python_ci.yml:
##
@@ -78,6 +78,6 @@ jobs:
shell: bash
run: |
set -e
- pip install dist/pyiceberg_c
sungwy opened a new pull request, #572:
URL: https://github.com/apache/iceberg-rust/pull/572
Currently, the dependency management is a bit awkward because we duplicate
the list of optional dependencies in `pyproject.toml` under
`[project.optional-dependencies]`, and then in
`.github/workfl
singhpk234 commented on PR #8044:
URL: https://github.com/apache/iceberg/pull/8044#issuecomment-2296979743
This has been raised in community a couple of times as at this point one has
to read code to see it's supported :
Relevant slack threads where this being documented could have helpe
singhpk234 commented on PR #9362:
URL: https://github.com/apache/iceberg/pull/9362#issuecomment-2296969461
cc @nastra @Fokko.
S3 Access point team PM and SA team requested the following doc change
request.
--
This is an automated message from the Apache Git Service.
To respond to t
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722038556
##
data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Xuanwo closed issue #205: SQL Catalog Implementation?
URL: https://github.com/apache/iceberg-rust/issues/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Xuanwo commented on issue #205:
URL: https://github.com/apache/iceberg-rust/issues/205#issuecomment-2296938105
The SQL catalog work has been started. Let's create a new tracking issue
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Xuanwo commented on issue #221:
URL: https://github.com/apache/iceberg-rust/issues/221#issuecomment-2296935953
No actions to take so far, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Xuanwo commented on issue #242:
URL: https://github.com/apache/iceberg-rust/issues/242#issuecomment-2296934785
Basic integration has been added in
https://github.com/apache/iceberg-rust/pull/324.
We can create a new tracking issues for missing pieces.
--
This is an automated messag
Xuanwo closed issue #242: Integrate with datafusion
URL: https://github.com/apache/iceberg-rust/issues/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
Xuanwo closed issue #239: Add gcs support in FileIO
URL: https://github.com/apache/iceberg-rust/issues/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
Xuanwo commented on issue #239:
URL: https://github.com/apache/iceberg-rust/issues/239#issuecomment-2296933470
Been added in https://github.com/apache/iceberg-rust/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Xuanwo commented on issue #495:
URL: https://github.com/apache/iceberg-rust/issues/495#issuecomment-2296930200
I believe this should have been fixed. Please feel free to open new issues
if still exists.
--
This is an automated message from the Apache Git Service.
To respond to the message
Xuanwo closed issue #495: Scan does not work as expected
URL: https://github.com/apache/iceberg-rust/issues/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Xuanwo commented on issue #562:
URL: https://github.com/apache/iceberg-rust/issues/562#issuecomment-2296893923
> I think it's
>
> `Literal -> RawLiteral -> Bytes` vs `Literal -> avro::Value -> Bytes`
I see. Thanks!
--
This is an automated message from the Apache Git Service.
xxchan commented on issue #562:
URL: https://github.com/apache/iceberg-rust/issues/562#issuecomment-2296891098
I think it's
`Literal -> RawLiteral -> Bytes` vs `Literal -> avro::Value -> Bytes`
--
This is an automated message from the Apache Git Service.
To respond to the message, p
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721988655
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721980729
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721979347
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
munendrasn commented on PR #10872:
URL: https://github.com/apache/iceberg/pull/10872#issuecomment-2296858187
@nastra
Updated, reverted the last commit in the PR
fe256b411363d1f884ce7a51a07f53b8fb9a797b
--
This is an automated message from the Apache Git Service.
To respond to the mess
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721978424
##
data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721975924
##
core/src/main/java/org/apache/iceberg/data/IdentityPartitionConverters.java:
##
@@ -48,6 +50,13 @@ public static Object convertConstant(Type type, Object
v
nastra commented on PR #128:
URL: https://github.com/apache/iceberg-go/pull/128#issuecomment-2296846237
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nastra commented on PR #10872:
URL: https://github.com/apache/iceberg/pull/10872#issuecomment-2296845324
> @nastra Thank you for the review, please let me know if I should moved the
`null` check to `getConf` or should we create new `Configuration` if not set?
@munendrasn yes I think i
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721966029
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721957929
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
zeroshade commented on PR #118:
URL: https://github.com/apache/iceberg-go/pull/118#issuecomment-2296822491
@nastra All rebased already :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
RussellSpitzer commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721954085
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
munendrasn commented on PR #10872:
URL: https://github.com/apache/iceberg/pull/10872#issuecomment-2296807136
@nastra Thank you for the review, please let me know if I should moved the
`null` check to `getConf` or should we create new `Configuration` if not set?
--
This is an automated mes
zeroshade commented on PR #128:
URL: https://github.com/apache/iceberg-go/pull/128#issuecomment-2296788984
@Fokko @nastra could one of you please have dependabot rebase these PRs? I'm
not a committer so I don't have permissions to make it rebase myself
--
This is an automated message from
nastra commented on PR #118:
URL: https://github.com/apache/iceberg-go/pull/118#issuecomment-2296770709
@zeroshade could you please rebase this one now that all the other PRs are
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nastra merged PR #10961:
URL: https://github.com/apache/iceberg/pull/10961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra merged PR #124:
URL: https://github.com/apache/iceberg-go/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
1 - 100 of 124 matches
Mail list logo
