edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-551926733
ORC is updated now to 1.6.1 and `TestReadProjection` for ORC is implemented
and passing.
Thi
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-545252732
@rdblue still working on this. I should have something for review by the end
of the week.
Th
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-536039841
@rdblue @rdsr Sorry I was out on holiday but I'll take a look at this today.
Thanks for the reviews.
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-530175403
@rdblue @rdsr this should be ready for another pass whenever you have some
chance, changes included:
* Using ORC v1.6.0
* Storing Iceberg column IDs in
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-530172606
@rdsr My plan was to get this column mapping in first and then rebase and
use in #199 since this PR would provide the right mapping.
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-527999715
@rdblue Yeah, I'll work on this today. I will update everyone once this is
ready for final review.
--
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-521789477
@linxingyuan1102 I agree, we need to specify the annotations for ORC column
mapping in the spec. I have a proposal in
https://github.com/apache/incubator-ice
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-514826275
@rdblue thanks for the follow up. Sounds good, I'll keep an eye on the ORC
release. Thanks!
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-51241
@rdblue Thanks for the follow up.
> The only other concern is that the ORC release with field-level properties
is imminent so we might want to wait for
edgarRd commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504867069
@rdblue @rdsr I agree to get this working before trying to fix ORC. I think
as long as we agree on how to persist the schema in ORC files, since that'll go
i
10 matches
Mail list logo