rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-571726987
+1
Thanks for all your work on this, @edgarRd! I'm merging it.
Also, thanks to @rdsr, @shardulm94, @lxynov, and @omalley for reviewing!
-
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-563026245
@shardulm94, the problem is that the generics should produce and consume
`OffsetDateTime` and `LocalDate`. I think we can fix that problem after this is
in (w
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-563025773
@edgarRd, this looks great! I think it just needs a few minor fixes and we
can commit it. Probably in the next week?
After that, I'm comfortable adding
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-544742914
@edgarRd, how is this one going? Is it close to being ready for review?
This is an automated m
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-531430613
Sorry that I haven't reviewed this yet! I was out for ApacheCon this week
and I'm going to be out until Wednesday next week. I'll have a look when I'm
back.
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-527967306
ORC 1.6.0 is released: https://orc.apache.org/news/2019/09/03/ORC-1.6.0/
@edgarRd, can you update this so we can get it in? I'd like to get it into a
re
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-521738363
Thanks for the update, @linxingyuan1102. It would be great to have your help
getting the spec updated. In the end, I think Presto should depend on Iceberg
to
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-514763224
@edgarRd, sorry about not following up sooner, I was unexpectedly out of the
office for the last few days. Since the ORC release is almost out, let's wait
for
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-512894755
@edgarRd, sorry for the delay on reviewing this again. I didn't realize it
had been updated. If you're waiting on me or another person for reviews, please
fee
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-508179219
Thanks for the updates, @edgarRd! I think this is getting close to merging.
This is an automat
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-505138230
@omalley, I think the proposal is not to write separate JSON files. It is to
embed the metadata in ORC's file-level properties. My point was that as long as
w
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504704779
@rdsr, are you proposing that we attach an alternative schema to a data
file? If so, why not just write the JSON form of the Iceberg schema? I like the
idea t
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504516042
Nice work, @edgarRd! I think this is pretty close. Eventually, I'd also like
to apply some of the schema tests that we use for Parquet and Avro to ORC to
vali
13 matches
Mail list logo
