[GitHub] [incubator-iceberg] rdblue commented on issue #349: Remove unreferenced hash computations

2019-08-27 Thread GitBox
rdblue commented on issue #349: Remove unreferenced hash computations URL: https://github.com/apache/incubator-iceberg/pull/349#issuecomment-525455644 +1 Thanks for fixing this @jbapple! This is an automated message

[GitHub] [incubator-iceberg] rdblue commented on issue #349: Remove unreferenced hash computations

2019-08-24 Thread GitBox
rdblue commented on issue #349: Remove unreferenced hash computations URL: https://github.com/apache/incubator-iceberg/pull/349#issuecomment-524583239 > I'm confused. They are valid types for bucketing? No, I just left out the "not" by accident.

[GitHub] [incubator-iceberg] rdblue commented on issue #349: Remove unreferenced hash computations

2019-08-24 Thread GitBox
rdblue commented on issue #349: Remove unreferenced hash computations URL: https://github.com/apache/incubator-iceberg/pull/349#issuecomment-524581190 I'm reluctant to completely remove these in case there is some legitimate reason to hash values in the future that requires specification.