[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-09-25 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-535226233 Got it. Should we add methods that allow you to set the partition name to the builder instead? ---

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-09-25 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-535194580 @prodeezy, I thought that method was internal and only used when parsing a spec. I didn't want the public API t

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-08-28 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525813417 Credit for this one should go to @fbocse, who authored the original PR. Looks like that was lost when GitHub di

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-08-28 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525812283 Thanks for reviewing, @aokolnychyi! I'll merge this. --

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-08-27 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525412584 @aokolnychyi, can you review this? This is an