Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-25 Thread via GitHub
viirya commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2077637850 Thanks @liurenjie1024. The roadmaps doc looks good to me. I added a few items under DataFusion integration. Feel free to modify it. Thanks. -- This is an automated message from

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-23 Thread via GitHub
liurenjie1024 commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2072455753 I've compiled a [doc](https://docs.google.com/document/d/1YncDX-qQ1T9jBGQmJNtRcPU1trRi00cB8eykv5diKw4/edit?usp=sharing) for discussing roadmaps and features for

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-16 Thread via GitHub
liurenjie1024 commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2059202270 I think to implement appending data file, there are two main tasks: 1. Implement transaction api to append data file 2. Implement file writer to write record

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-16 Thread via GitHub
Fokko commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2058636547 @marvinlanhenke Sorry for being late to the party here. Appending a file is rather straightforward, but all the conditions must be met. This is the high-level way of appending a

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-09 Thread via GitHub
sdd commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2044235422 > This should probably accept a RecordBatch as a param, create a new Transaction, and delegates further action to the transaction. Is there a reason why append wouldn't take a

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-07 Thread via GitHub
viirya commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2041597213 > calling the writer to write the DataFile create an instance of MergingSnapshotProducer -> responsible for writing the manifest, manifest_list, snapshot_update commit ->

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-07 Thread via GitHub
marvinlanhenke commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2041548391 > I'm not sure whether my understanding is correct: The target of `table.append()` is used to insert a batch of data into the table. It's seems like a high level API which

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-07 Thread via GitHub
ZENOTME commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2041528557 I'm not sure whether my understanding is correct: The target of `table.append()` is used to insert a batch of data into the table. It's seems like a high level API which will

Re: [I] Discussion: Next steps / requirements to support `append` files [iceberg-rust]

2024-04-07 Thread via GitHub
sdd commented on issue #329: URL: https://github.com/apache/iceberg-rust/issues/329#issuecomment-2041520090 Thanks for spending the time thinking about this and putting your thoughts into words. I need to spend some time re-reading the associated parts of the spec and looking through the