Re: [I] Implement the equality delete writer [iceberg-rust]

2024-05-06 Thread via GitHub
ZENOTME commented on issue #341: URL: https://github.com/apache/iceberg-rust/issues/341#issuecomment-2095637090 Thanks! @Dysprosium0626 Sorry for replying late. Our original idea here is to construct the delete schema outside the EqualityDeleteFileWriter. ``` let equality_ids = vec![

Re: [I] Implement the equality delete writer [iceberg-rust]

2024-05-06 Thread via GitHub
ZENOTME commented on issue #341: URL: https://github.com/apache/iceberg-rust/issues/341#issuecomment-2095633576 Thanks! @Dysprosium0626 Sorry for replying late. Our original idea here is to construct the delete schema outside the EqualityDeleteFileWriter. ``` let equality_ids = vec![

Re: [I] Implement the equality delete writer [iceberg-rust]

2024-05-04 Thread via GitHub
Dysprosium0626 commented on issue #341: URL: https://github.com/apache/iceberg-rust/issues/341#issuecomment-2094225277 Hi I nearly complete adding `EqualityDeleteWriter` but I encounter some problem. My impl is here: https://github.com/Dysprosium0626/iceberg-rust/blob/add_equality_delete

Re: [I] Implement the equality delete writer [iceberg-rust]

2024-04-25 Thread via GitHub
liurenjie1024 commented on issue #341: URL: https://github.com/apache/iceberg-rust/issues/341#issuecomment-2076878340 Assigned to you, thanks @Dysprosium0626 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[I] Implement the equality delete writer [iceberg-rust]

2024-04-22 Thread via GitHub
ZENOTME opened a new issue, #341: URL: https://github.com/apache/iceberg-rust/issues/341 After we finish https://github.com/apache/iceberg-rust/pull/275, we can implement the equality delete writer based on this framework. There is a [rust implementation](https://github.com/icelake-i