Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-2338019734 I'll close this issue because we added the mypy linter, which solves our problem with coupling, and we have #1099 to solve the public API definition. -- This is an automated m

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis closed issue #499: Library public api isolation and import decoupling URL: https://github.com/apache/iceberg-python/issues/499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1991736688 We have some news about the issue: mypy has implemented a rule that could protect us. You can find more details here: https://mypy.readthedocs.io/en/stable/config_file.html#conf

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1985907062 Issue to follow up https://github.com/astral-sh/ruff/issues/10300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1985722458 @kevinjqliu Agreed, I haven't found anything that addresses this issue or provides a warning when it occurs. It seems like something the community has accepted, but I believe it

Re: [I] Library public api isolation and import decoupling [iceberg-python]

kevinjqliu commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1984611888 Thanks for the PR! Do you know if there are ways to do this systemically, with linters / rules? I foresee this to be an issue again as we continue to do more development.

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1984450634 The #505 decouple imports from * pyiceberg.catalog * pyiceberg.table * pyiceberg.expressions -- This is an automated message from the Apache Git Service. To respon

Re: [I] Library public api isolation and import decoupling [iceberg-python]

ndrluis commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1980691856 @HonahX Yes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] Library public api isolation and import decoupling [iceberg-python]

HonahX commented on issue #499: URL: https://github.com/apache/iceberg-python/issues/499#issuecomment-1980189490 @ndrluis Thanks for reporting this! I think we should fix these to import from the right module. Do you want to work on this? -- This is an automated message from the Apache Gi

[I] Library public api isolation and import decoupling [iceberg-python]

ndrluis opened a new issue, #499: URL: https://github.com/apache/iceberg-python/issues/499 ### Feature Request / Improvement Hello, when I was trying to solve the #497 issue, I noticed that we are exposing the private API and we have some imports through modules. For example,