Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-06-13 Thread via GitHub
liurenjie1024 closed issue #385: bug: Iceberg opendal missing s3 support URL: https://github.com/apache/iceberg-rust/issues/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-06-01 Thread via GitHub
Xuanwo commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2143364184 Let me fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-31 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2141754544 > Maybe we can add features like `storage-s3`, `storage-gcs` at the iceberg side. +1 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-31 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2141620053 Good catch! Thanks @c-thiel for the finding! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-31 Thread via GitHub
c-thiel commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2141384589 > BTW how the integration tests passed when s3 is not included? I think at least [this test](https://github.com/apache/iceberg-rust/blob/048eac801f09ca58e610a020db2e29bd95c22db0/c

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2139653246 BTW how the integration tests passed when s3 is not included? I think at least [this test](https://github.com/apache/iceberg-rust/blob/048eac801f09ca58e610a020db2e29bd95c22d

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-30 Thread via GitHub
liurenjie1024 commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2139649747 > I believe we should enable the storage we want in `iceberg` crate. Will this cause the library to include unnecessary dependencies? I think using features to control

Re: [I] bug: Iceberg opendal missing s3 support [iceberg-rust]

2024-05-28 Thread via GitHub
Xuanwo commented on issue #385: URL: https://github.com/apache/iceberg-rust/issues/385#issuecomment-2135636174 I believe we should enable the storage we want in `iceberg` crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub