Re: [PR] API, Spark: Add fastForwardOrCreate API and integrate that with Spark fast forward procedure [iceberg]

2023-12-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #9196: URL: https://github.com/apache/iceberg/pull/9196#discussion_r1412683806 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java: ## @@ -73,19 +71,16 @@ public StructType outputType() {

Re: [PR] API, Spark: Add fastForwardOrCreate API and integrate that with Spark fast forward procedure [iceberg]

2023-12-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #9196: URL: https://github.com/apache/iceberg/pull/9196#discussion_r1412683256 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java: ## @@ -73,19 +71,16 @@ public StructType outputType() {

Re: [PR] API, Spark: Add fastForwardOrCreate API and integrate that with Spark fast forward procedure [iceberg]

2023-12-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #9196: URL: https://github.com/apache/iceberg/pull/9196#discussion_r1412683256 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java: ## @@ -73,19 +71,16 @@ public StructType outputType() {

[PR] API, Spark: Add fastForwardOrCreate API and integrate that with Spark fast forward procedure [iceberg]

2023-12-01 Thread via GitHub
amogh-jahagirdar opened a new pull request, #9196: URL: https://github.com/apache/iceberg/pull/9196 Fixes #8849 This change adds a `fastForwardOrCreate` API which will perform a fast forward of the `from` branch if it exists; otherwise `from` will be created and pointing towards