aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2111361552
Thank you @geruh @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
amogh-jahagirdar merged PR #10199:
URL: https://github.com/apache/iceberg/pull/10199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
geruh commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2111348073
Awesome work @aajisaka, looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1600313072
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,9 @@ void persistGlueTable(
.skipArchive(awsProperties.gl
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1600221414
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,9 @@ void persistGlueTable(
.skipArchive(awsPrope
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1600221414
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,9 @@ void persistGlueTable(
.skipArchive(awsPrope
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599419966
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.g
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599418688
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##
@@ -206,6 +208,15 @@ public void testUpdateTable() {
.isEqualTo("EXTER
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599418533
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProperties.g
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192463
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProp
amogh-jahagirdar commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1599192267
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -316,6 +316,11 @@ void persistGlueTable(
.skipArchive(awsProp
aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2100651509
Hi @geruh @amogh-jahagirdar would you review the latest change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
aajisaka commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1585860715
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -322,6 +322,7 @@ void persistGlueTable(
.name(tableName)
geruh commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1585580662
##
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##
@@ -322,6 +322,7 @@ void persistGlueTable(
.name(tableName)
aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2084524941
Hi @geruh would you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2076564061
Also, I built the jars and manually tested on AWS Glue as a Spark runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2076512208
I ran the integration test using my AWS account and the `testUpdateTable()`
was successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
aajisaka commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2072339019
Thank you for your suggestion @geruh
I'll test this patch manually and update the class.
--
This is an automated message from the Apache Git Service.
To respond to the message
geruh commented on PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2070875152
Awesome, thanks for contributing this @aajisaka! Manually did this change
work? For adding some tests, if the unit test logic in this module is
difficult. I'd suggest leveraging this modu
aajisaka opened a new pull request, #10199:
URL: https://github.com/apache/iceberg/pull/10199
## Problem
In AWS Glue Catalog, user can set arbitrary description to the table and its
columns via Web UI or even from Amazon Athena. However, the descriptions will
be removed after upgradi
20 matches
Mail list logo
