Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

Fokko commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1577458027 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,466 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1577440808 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1577440808 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1577106941 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,466 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2073844403 > There are intentionally a lot of `todo!`s in here. The aim is to get this PR merged so that more people can contribute implementations for the different visitor methods that

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

Fokko commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1576805382 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,466 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

Fokko commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1576800710 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

Fokko commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1576798073 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,466 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 merged PR #322: URL: https://github.com/apache/iceberg-rust/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1574198729 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

ZENOTME commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1574193520 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1574191566 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1574182261 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

ZENOTME commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1574157028 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

marvinlanhenke commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2068159189 @sdd Thanks a lot. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2068041946 cc @Xuanwo @Fokko @marvinlanhenke PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2068041808 Let's wait to see if others have comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1573750563 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,459 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2067105023 Thanks for the reviews, @marvinlanhenke and @liurenjie1024! All comments addressed and ready for re-review  -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572759976 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572759092 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572759566 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572758803 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

liurenjie1024 commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572472267 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572265647 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572263328 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

marvinlanhenke commented on code in PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#discussion_r1572246030 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -0,0 +1,393 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2065971864 There are intentionally a lot of `todo!`s in here. The aim is to get this PR merged so that more people can contribute implementations for the different visitor methods that need

Re: [PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd commented on PR #322: URL: https://github.com/apache/iceberg-rust/pull/322#issuecomment-2065967273 @Fokko @liurenjie1024 @marvinlanhenke: I've rebased this on top of main now that the `InclusiveProjection` has been merged and it would be good to get some initial feedback. -- This is

[PR] Add `ManifestEvaluator`, used to filter manifests in table scans [iceberg-rust]

sdd opened a new pull request, #322: URL: https://github.com/apache/iceberg-rust/pull/322 This PR has been broken out of https://github.com/apache/iceberg-rust/pull/241 as that PR was getting too large. It depends on https://github.com/apache/iceberg-rust/pull/320 and