Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-08-12 Thread via GitHub
ajantha-bhat commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1713869763 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.add

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-08-12 Thread via GitHub
Fokko commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1713644175 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sna

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-20 Thread via GitHub
findepi commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1607253850 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(s

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-20 Thread via GitHub
ajantha-bhat commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1594277743 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java: ## @@ -180,8 +181,10 @@ public void testBinPackUnpartitionedT

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-08 Thread via GitHub
ajantha-bhat commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1594265875 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.add

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-07 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1592861026 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sn

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-03 Thread via GitHub
dramaticlly commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589716377 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addA

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-03 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589621767 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sn

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-03 Thread via GitHub
jbonofre commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589368924 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-05-02 Thread via GitHub
amogh-jahagirdar commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1588511039 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1585147537 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sn

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1585139953 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sn

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
jbonofre commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584935556 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
Fokko commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584982185 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sna

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
Fokko commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584982185 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(sna

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-30 Thread via GitHub
jbonofre commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584935556 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -156,6 +156,8 @@ public List apply(TableMetadata base, Snapshot snapshot) { manifests.addAll(

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-29 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584137262 ## core/src/main/java/org/apache/iceberg/SnapshotSummary.java: ## @@ -263,6 +273,12 @@ void addTo(ImmutableMap.Builder builder) { setIf(removedDeleteFiles > 0,

Re: [PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-29 Thread via GitHub
nk1506 commented on code in PR #10246: URL: https://github.com/apache/iceberg/pull/10246#discussion_r1584136686 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -190,6 +190,7 @@ public List apply(TableMetadata base, Snapshot snapshot) { List apply

[PR] Add ManifestFile Stats in snapshot summary. [iceberg]

2024-04-29 Thread via GitHub
nk1506 opened a new pull request, #10246: URL: https://github.com/apache/iceberg/pull/10246 Currently snapshot summary doesn't have statistics related to Manifest Files. This change is adding two new summary fields `"total-data-manifest-files"` and `"total-delete-manifest-files"`. Ther