liurenjie1024 merged PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#issuecomment-2015064278
I'll merge this first to move on. We can refine it later if others have
comments, thanks @marvinlanhenke
--
This is an automated message from the Apache Git Service.
To respon
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1533287398
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,376 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
liurenjie1024 commented on PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#issuecomment-2011188349
cc @Xuanwo @Fokko PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1533226902
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1533224715
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,376 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1532158867
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1532076339
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1532004592
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1532007739
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1532001666
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531952526
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
marvinlanhenke commented on PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#issuecomment-2009409832
@liurenjie1024
I fixed most of the issues / suggestions - thanks again.
Still unresolved / left to discuss:
- keeping file_io in `HmsCatalog`
- using `flush()` in
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531961903
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531899038
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531862232
##
crates/catalog/hms/tests/hms_catalog_test.rs:
##
@@ -56,19 +63,182 @@ async fn set_test_fixture(func: &str) -> TestFixture {
}
}
+let p
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531715065
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531794765
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531899038
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531803665
##
crates/catalog/hms/src/utils.rs:
##
@@ -157,6 +150,57 @@ pub(crate) fn convert_to_database(
Ok(db)
}
+pub(crate) fn convert_to_hive_table(
+db_
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531889030
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531785072
##
crates/catalog/hms/src/error.rs:
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531891267
##
crates/catalog/hms/src/schema.rs:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531855515
##
crates/catalog/hms/src/utils.rs:
##
@@ -183,6 +227,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result {
Ok(name)
}
+///
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531800011
##
crates/catalog/hms/src/utils.rs:
##
@@ -183,6 +227,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result {
Ok(name)
}
+///
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531784021
##
crates/catalog/hms/src/catalog.rs:
##
@@ -47,6 +56,8 @@ pub enum HmsThriftTransport {
pub struct HmsCatalogConfig {
address: String,
thrift_tran
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531728196
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531715065
##
crates/catalog/hms/src/catalog.rs:
##
@@ -287,31 +307,203 @@ impl Catalog for HmsCatalog {
Ok(tables)
}
+/// Creates a new table within
marvinlanhenke commented on PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#issuecomment-2009071600
> @marvinlanhenke This pr is amazing! I found some small problems to
improve, but it looks great to me overall, thanks!
thanks for the extensive review - I'll get to the f
liurenjie1024 commented on code in PR #285:
URL: https://github.com/apache/iceberg-rust/pull/285#discussion_r1531431294
##
crates/catalog/hms/src/error.rs:
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
marvinlanhenke opened a new pull request, #285:
URL: https://github.com/apache/iceberg-rust/pull/285
### Which issue does this PR close?
Closes #113
### Rationale for this change
Add hive metastore support, to reach feature parity with other iceberg
implementations.
### W
31 matches
Mail list logo
