Re: [PR] Address Intellij inspection findings [iceberg]

nastra merged PR #10583: URL: https://github.com/apache/iceberg/pull/10583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Address Intellij inspection findings [iceberg]

nastra commented on code in PR #10583: URL: https://github.com/apache/iceberg/pull/10583#discussion_r1664024915 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -410,7 +410,7 @@ private void checkAndAddPartitionName(String name, Integer sourceColumnId) {

Re: [PR] Address Intellij inspection findings [iceberg]

snazy commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205653868 > We're improving the code and the null check is being removed "improving code" is very broad - and the null-check was never hit. Really - this PR is meant to address the intellij f

Re: [PR] Address Intellij inspection findings [iceberg]

nastra commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205538061 > > should be good to go once https://github.com/apache/iceberg/pull/10583/files#r1663651011 has been addressed > > Sorry, it's really out of scope of this PR ("Adress IntelliJ In

Re: [PR] Address Intellij inspection findings [iceberg]

snazy commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205497949 > should be good to go once https://github.com/apache/iceberg/pull/10583/files#r1663651011 has been addressed Sorry, it's really out of scope of this PR ("Adress IntelliJ Inspectio

Re: [PR] Address Intellij inspection findings [iceberg]

nastra commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205486386 should be good to go once https://github.com/apache/iceberg/pull/10583/files#r1663651011 has been addressed -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Address Intellij inspection findings [iceberg]

snazy commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205375422 Repeating my note from above: IMHO no _functional_ or potentially _user facing_ changes should go into this PR. Going to rebase this once more due to the conflict. -- This is an auto

Re: [PR] Address Intellij inspection findings [iceberg]

nastra commented on code in PR #10583: URL: https://github.com/apache/iceberg/pull/10583#discussion_r1663651011 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -410,7 +410,7 @@ private void checkAndAddPartitionName(String name, Integer sourceColumnId) {

Re: [PR] Address Intellij inspection findings [iceberg]

ajantha-bhat commented on PR #10583: URL: https://github.com/apache/iceberg/pull/10583#issuecomment-2205181608 > The PR is already quite large and given that we need to fix those things across all Flink/Spark versions I'd suggest to extract the Flink/Spark related things into a separate PR

Re: [PR] Address Intellij inspection findings [iceberg]

nastra commented on code in PR #10583: URL: https://github.com/apache/iceberg/pull/10583#discussion_r1662586692 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -410,7 +410,7 @@ private void checkAndAddPartitionName(String name, Integer sourceColumnId) {