Re: [PR] Allow filtering on newly added columns [iceberg-python]

2024-01-03 Thread via GitHub
Fokko merged PR #246: URL: https://github.com/apache/iceberg-python/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Allow filtering on newly added columns [iceberg-python]

2024-01-03 Thread via GitHub
Fokko commented on code in PR #246: URL: https://github.com/apache/iceberg-python/pull/246#discussion_r1440214517 ## pyiceberg/expressions/visitors.py: ## @@ -906,7 +906,16 @@ def visit_bound_predicate(self, predicate: BoundPredicate[L]) -> BooleanExpressi def translate_co

Re: [PR] Allow filtering on newly added columns [iceberg-python]

2024-01-03 Thread via GitHub
Fokko commented on code in PR #246: URL: https://github.com/apache/iceberg-python/pull/246#discussion_r1440208230 ## tests/test_integration.py: ## @@ -373,6 +379,15 @@ def test_scan_branch(test_positional_mor_deletes: Table) -> None: assert arrow_table["number"].to_pylist(

Re: [PR] Allow filtering on newly added columns [iceberg-python]

2024-01-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #246: URL: https://github.com/apache/iceberg-python/pull/246#discussion_r1439112448 ## pyiceberg/expressions/visitors.py: ## @@ -906,7 +906,16 @@ def visit_bound_predicate(self, predicate: BoundPredicate[L]) -> BooleanExpressi def t

[PR] Allow filtering on newly added columns [iceberg-python]

2024-01-01 Thread via GitHub
Fokko opened a new pull request, #246: URL: https://github.com/apache/iceberg-python/pull/246 Resolves #217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,