Re: [PR] Avro: Add Avro-assisted name mapping [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on PR #7392: URL: https://github.com/apache/iceberg/pull/7392#issuecomment-1868128440 Thanks, @wmoustafa! Good to have the ability to generate these mappings. Can you also update `ApplyNameMapping` to use them? It was added in https://github.com/apache/iceberg/pull/9347.

Re: [PR] Avro: Add Avro-assisted name mapping [iceberg]

2023-12-22 Thread via GitHub
rdblue merged PR #7392: URL: https://github.com/apache/iceberg/pull/7392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Avro: Add Avro-assisted name mapping [iceberg]

2023-10-10 Thread via GitHub
wmoustafa commented on PR #7392: URL: https://github.com/apache/iceberg/pull/7392#issuecomment-1756153921 > I think this is ready. Just a few minor updates needed; mostly https://github.com/apache/iceberg/pull/7392/files#r1224853756. Addressed. -- This is an automated message from

Re: [PR] Avro: Add Avro-assisted name mapping [iceberg]

2023-10-10 Thread via GitHub
wmoustafa commented on code in PR #7392: URL: https://github.com/apache/iceberg/pull/7392#discussion_r1353271608 ## core/src/main/java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java: ## @@ -93,14 +94,23 @@ private static T visitRecord( private static T visit