Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

HonahX merged PR #848: URL: https://github.com/apache/iceberg-python/pull/848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

syun64 commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1671326003 ## pyiceberg/catalog/__init__.py: ## @@ -675,8 +675,11 @@ def _convert_schema_if_needed(schema: Union[Schema, "pa.Schema"]) -> Schema: from pyiceber

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667417979 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667417924 ## pyiceberg/catalog/__init__.py: ## @@ -675,8 +675,11 @@ def _convert_schema_if_needed(schema: Union[Schema, "pa.Schema"]) -> Schema: from pyiceberg

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

syun64 commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667216339 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

syun64 commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667028145 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666586779 ## mkdocs/docs/configuration.md: ## @@ -299,4 +299,8 @@ PyIceberg uses multiple threads to parallelize operations. The number of workers # Backward Compatibility

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666824972 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666824972 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666823874 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r144991 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666586779 ## mkdocs/docs/configuration.md: ## @@ -299,4 +299,8 @@ PyIceberg uses multiple threads to parallelize operations. The number of workers # Backward Compatibility

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1666586081 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.t

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

HonahX commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1665113108 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

corleyma commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1663349324 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif p

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

HonahX commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1650427316 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

Fokko commented on PR #848: URL: https://github.com/apache/iceberg-python/pull/848#issuecomment-2184921011 Thanks @syun64 for working on this! 🙌 > Question: Are timestamp_ns and timestamptz_ns already supported? If so, should we just limit this PR to casting 's' and 'ms' to 'us' prec