Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar merged PR #10026: URL: https://github.com/apache/iceberg/pull/10026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar commented on PR #10026: URL: https://github.com/apache/iceberg/pull/10026#issuecomment-2018998345 Merging, thanks for the reviews @RussellSpitzer @nastra ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1538289522 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -218,6 +218,44 @@ public void test

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1538240118 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -261,6 +261,44 @@ public void test

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
nastra commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1537421016 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -261,6 +261,44 @@ public void testRewriteDat

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
nastra commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1537421016 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -261,6 +261,44 @@ public void testRewriteDat

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
nastra commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1537376429 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -261,6 +261,44 @@ public void testRewriteDat

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-25 Thread via GitHub
nastra commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1537376429 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -261,6 +261,44 @@ public void testRewriteDat

Re: [PR] Core, Spark: Fix handling of null binary values when sorting with zorder [iceberg]

2024-03-22 Thread via GitHub
RussellSpitzer commented on code in PR #10026: URL: https://github.com/apache/iceberg/pull/10026#discussion_r1536007907 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -218,6 +218,44 @@ public void testRe