Re: [PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-22 Thread via GitHub
rdblue merged PR #9347: URL: https://github.com/apache/iceberg/pull/9347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on PR #9347: URL: https://github.com/apache/iceberg/pull/9347#issuecomment-1868096519 Thanks for reviewing, @Fokko! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9347: URL: https://github.com/apache/iceberg/pull/9347#discussion_r1435310822 ## core/src/main/java/org/apache/iceberg/avro/ApplyNameMapping.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9347: URL: https://github.com/apache/iceberg/pull/9347#discussion_r1435310612 ## core/src/main/java/org/apache/iceberg/avro/ApplyNameMapping.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-21 Thread via GitHub
Fokko commented on code in PR #9347: URL: https://github.com/apache/iceberg/pull/9347#discussion_r1433693770 ## core/src/main/java/org/apache/iceberg/avro/ApplyNameMapping.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[PR] Core: Add ApplyNameMapping for Avro [iceberg]

2023-12-19 Thread via GitHub
rdblue opened a new pull request, #9347: URL: https://github.com/apache/iceberg/pull/9347 This separates the logic to apply a name mapping from the logic to prune columns in Avro. This is some cleanup since name mapping shouldn't be mixed with column pruning. -- This is an automated mess