Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-06 Thread via GitHub
aokolnychyi commented on PR #9194: URL: https://github.com/apache/iceberg/pull/9194#issuecomment-1843990810 Thanks for reviewing, @qqqttt123 @jerqi @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-06 Thread via GitHub
aokolnychyi merged PR #9194: URL: https://github.com/apache/iceberg/pull/9194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-06 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1418166520 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-06 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1418166372 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-06 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1418028589 ## core/src/main/java/org/apache/iceberg/util/PartitionSet.java: ## @@ -32,7 +33,7 @@ import org.apache.iceberg.relocated.com.google.common.collect.Maps; import o

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416381792 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416379643 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416376393 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416374500 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416374206 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416356324 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416348617 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416347669 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416344322 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416341234 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416341234 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416341234 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416338150 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416328166 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416327633 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416323437 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416323437 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416320230 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416316893 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
RussellSpitzer commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416300233 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-05 Thread via GitHub
aokolnychyi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1416017260 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-03 Thread via GitHub
jerqi commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1413426617 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-03 Thread via GitHub
qqqttt123 commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1413424718 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core: Add PartitionMap [iceberg]

2023-12-03 Thread via GitHub
qqqttt123 commented on code in PR #9194: URL: https://github.com/apache/iceberg/pull/9194#discussion_r1413424718 ## core/src/main/java/org/apache/iceberg/util/PartitionMap.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[PR] Core: Add PartitionMap [iceberg]

2023-12-01 Thread via GitHub
aokolnychyi opened a new pull request, #9194: URL: https://github.com/apache/iceberg/pull/9194 This PR adds `PartitionMap`, a map that uses a pair of spec ID and partition tuple as keys. It is similar to `PartitionSet`. The class will simplify places like `DeleteFileIndex` that uses t