[PR] Core: Add support for view-default property in catalog [iceberg]

2024-09-24 Thread via GitHub
nk1506 opened a new pull request, #11200: URL: https://github.com/apache/iceberg/pull/11200 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-12 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1757698066 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -85,7 +85,8 @@ static RESTCatalog initCatalogClient() { catalogProperties.putIfAbsen

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-12 Thread via GitHub
nk1506 commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1756984629 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -29,6 +29,7 @@ private CatalogProperties() {} public static final String WAREHOUSE_LOCATION =

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-09 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1750255921 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +108,7 @@ public void basicCreateView() { assertThat(view.currentVersion().opera

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-09 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1750254414 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -85,7 +85,8 @@ static RESTCatalog initCatalogClient() { catalogProperties.putIfAbse

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-03 Thread via GitHub
singhpk234 commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1742360146 ## docs/docs/spark-configuration.md: ## @@ -77,6 +77,8 @@ Both catalogs are configured using properties nested under the catalog name. Com | spark.sql.catalog._c

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-02 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2325282952 @RussellSpitzer Can you review this PR when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-02 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2324566532 CI hit https://github.com/apache/iceberg/issues/10172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-01 Thread via GitHub
ebyhr opened a new pull request, #11064: URL: https://github.com/apache/iceberg/pull/11064 Fixes #10822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma