Re: [PR] Core: Always use delete index for position deletes [iceberg]

2023-11-20 Thread via GitHub
aokolnychyi commented on PR #9117: URL: https://github.com/apache/iceberg/pull/9117#issuecomment-1819963551 cc @amogh-jahagirdar @nastra @RussellSpitzer @flyrain @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Core: Always use delete index for position deletes [iceberg]

2023-11-20 Thread via GitHub
aokolnychyi commented on code in PR #9117: URL: https://github.com/apache/iceberg/pull/9117#discussion_r1399860140 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -245,18 +242,9 @@ private CloseableIterable applyPosDeletes(CloseableIterable records) {

Re: [PR] Core: Always use delete index for position deletes [iceberg]

2023-11-20 Thread via GitHub
aokolnychyi commented on code in PR #9117: URL: https://github.com/apache/iceberg/pull/9117#discussion_r1399860140 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -245,18 +242,9 @@ private CloseableIterable applyPosDeletes(CloseableIterable records) {