Re: [PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
ajantha-bhat commented on PR #9853: URL: https://github.com/apache/iceberg/pull/9853#issuecomment-1975066720 LGTM. How can we catch these errors early? Can we add the testcase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
danielcweeks merged PR #9853: URL: https://github.com/apache/iceberg/pull/9853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
rdblue commented on PR #9853: URL: https://github.com/apache/iceberg/pull/9853#issuecomment-1974887622 Okay, I can confirm that this fixes the problem locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
rdblue commented on code in PR #9853: URL: https://github.com/apache/iceberg/pull/9853#discussion_r1510022119 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1058,12 +1058,17 @@ public List listViews(SessionContext context, Namespace namespa pub

Re: [PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
danielcweeks commented on code in PR #9853: URL: https://github.com/apache/iceberg/pull/9853#discussion_r1510022083 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1058,12 +1058,17 @@ public List listViews(SessionContext context, Namespace namespa

[PR] Core: Fix REST catalog handling when the service has no view support [iceberg]

2024-03-02 Thread via GitHub
rdblue opened a new pull request, #9853: URL: https://github.com/apache/iceberg/pull/9853 This is a fix for Spark table loading when a REST catalog does not support view extensions. The problem is that Spark runs `ResolveViews` before `ResolveTables` in the substitution batch of rule