Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-05 Thread via GitHub
nastra merged PR #10369: URL: https://github.com/apache/iceberg/pull/10369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-04 Thread via GitHub
hantangwangd commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665997350 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops, UpdateTable

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665910677 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) { // it is only safe to

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665909446 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops, UpdateT

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-02 Thread via GitHub
amogh-jahagirdar commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1653278618 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops, UpdateT

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-07-02 Thread via GitHub
amogh-jahagirdar commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1653259556 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops, UpdateT

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-04 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1625500488 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) { // it is only safe to set the fo

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1625428863 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) { // it is only safe to set the fo

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1625424655 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -2581,6 +2583,45 @@ public void testConcurrentReplaceTransactionSortOrderConflict() { a

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
hantangwangd commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624864787 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,8 +374,7 @@ private static TableMetadata create(TableOperations ops, UpdateTableR

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
hantangwangd commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624863729 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2655,6 +2656,68 @@ public void testCleanupCleanableExceptionsReplace() { .isI

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
hantangwangd commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624862497 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -861,6 +862,19 @@ public static Builder buildFromEmpty() { return new Builder(); } +

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624512760 ## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ## @@ -374,8 +374,7 @@ private static TableMetadata create(TableOperations ops, UpdateTableRequest

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624502953 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -861,6 +862,19 @@ public static Builder buildFromEmpty() { return new Builder(); } + publ

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624509499 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2655,6 +2656,68 @@ public void testCleanupCleanableExceptionsReplace() { .isInstanc

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624504977 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2655,6 +2656,68 @@ public void testCleanupCleanableExceptionsReplace() { .isInstanc

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10369: URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624502953 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -861,6 +862,19 @@ public static Builder buildFromEmpty() { return new Builder(); } + publ

Re: [PR] Core: Fix create v1 table on REST Catalog [iceberg]

2024-05-28 Thread via GitHub
hantangwangd commented on PR #10369: URL: https://github.com/apache/iceberg/pull/10369#issuecomment-2135076025 Hi @nastra, can you please take a look at this fix when available? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please lo