Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra merged PR #9131: URL: https://github.com/apache/iceberg/pull/9131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on PR #9131: URL: https://github.com/apache/iceberg/pull/9131#issuecomment-1840521246 Thanks for reviewing this @rdblue, I've applied your feedback and also moved the VERSION AS OF handling to https://github.com/apache/iceberg/pull/9219 -- This is an automated message fro

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1415086590 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -173,6 +173,10 @@ public Long snapshotId() { return snapshotId; } + p

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1415084740 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -419,6 +420,12 @@ public void testInvalidTimeTravelBasedOnBothAsOfAndTableIdentifi

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1415055875 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,56 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1414416904 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -419,6 +420,12 @@ public void testInvalidTimeTravelBasedOnBothAsOfAndTableIdentifi

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1414414566 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,56 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1414414566 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,56 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1414410572 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java: ## @@ -173,6 +173,10 @@ public Long snapshotId() { return snapshotId; } + p

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1404544526 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -171,7 +171,7 @@ public Table loadTable(Identifier ident, String version) throws NoS

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1403420355 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -171,7 +171,7 @@ public Table loadTable(Identifier ident, String version) throws NoS

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1403181705 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,35 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1403161057 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,35 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

nastra commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1403161057 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,35 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1402479551 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,35 @@ public void testSnapshotSelectionByBranchWithSche

Re: [PR] Core: Schema for a branch should return table schema [iceberg]

rdblue commented on code in PR #9131: URL: https://github.com/apache/iceberg/pull/9131#discussion_r1402477101 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java: ## @@ -425,16 +426,35 @@ public void testSnapshotSelectionByBranchWithSche

[PR] Core: Schema for a branch should return table schema [iceberg]

nastra opened a new pull request, #9131: URL: https://github.com/apache/iceberg/pull/9131 When retrieving the schema for branch we should always return the table schema instead of the snapshot schema. This is because the table schema is the schema that will be used when the branch will be c