nastra commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1800809705
##
core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java:
##
@@ -176,6 +178,52 @@ public void testResolvingFileIOLoad() {
assertThat(result).isInstan
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1799817673
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -74,7 +74,7 @@ public HadoopFileIO(SerializableSupplier
hadoopConf) {
}
public Con
nastra commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1799473360
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -74,7 +74,7 @@ public HadoopFileIO(SerializableSupplier
hadoopConf) {
}
public Config
stevenzwu commented on PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#issuecomment-2402802516
> @stevenzwu for Option 1, wouldn't
https://github.com/apache/iceberg/pull/10926/files#r1718243019 also solve the
issue with the NPE without introducing a Hadoop dependency on the Par
stevenzwu commented on PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#issuecomment-2379987754
> I don't think that we should change how this works. A Hadoop Configuration
MUST be provided externally.
This makes sense. We already have some consensus that the current PR ne
rdblue commented on PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#issuecomment-2379910160
I don't think that we should change how this works. A Hadoop Configuration
MUST be provided externally. FileIO serialization is not intended to send the
entire Hadoop Configuration and s
pvary commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1750267503
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
pvary commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1739186116
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1736772930
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1736772930
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
pvary commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1735204259
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734784202
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734784202
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734784202
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734784202
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
pvary commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734538084
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
pvary commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734538084
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
Fokko commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1734473138
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
stevenzwu commented on code in PR #10926:
URL: https://github.com/apache/iceberg/pull/10926#discussion_r1733692980
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##
@@ -63,7 +63,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
19 matches
Mail list logo