Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2024-01-03 Thread via GitHub
ajantha-bhat commented on PR #9305: URL: https://github.com/apache/iceberg/pull/9305#issuecomment-1876393081 > There is also a partition stats file added recently https://github.com/apache/iceberg/commit/6e21bbf4c4cd2c8351a64636f91d05d00492dff2 We should handle this for them aswell.

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2024-01-03 Thread via GitHub
amogh-jahagirdar merged PR #9305: URL: https://github.com/apache/iceberg/pull/9305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-20 Thread via GitHub
ajantha-bhat commented on code in PR #9305: URL: https://github.com/apache/iceberg/pull/9305#discussion_r1432657742 ## core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java: ## @@ -181,4 +205,34 @@ private Set metadataLocations(TableMetadata tableMetadata)

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-20 Thread via GitHub
ajantha-bhat commented on PR #9305: URL: https://github.com/apache/iceberg/pull/9305#issuecomment-1864264195 There is also a partition stats file added recently https://github.com/apache/iceberg/commit/6e21bbf4c4cd2c8351a64636f91d05d00492dff2 We should handle this for them aswell.

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-18 Thread via GitHub
dramaticlly commented on code in PR #9305: URL: https://github.com/apache/iceberg/pull/9305#discussion_r1430486073 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -117,6 +117,11 @@ public static void dropTableData(FileIO io, TableMetadata metadata) {

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-15 Thread via GitHub
ajantha-bhat commented on code in PR #9305: URL: https://github.com/apache/iceberg/pull/9305#discussion_r1427885903 ## core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java: ## @@ -38,19 +49,28 @@ public class TestCatalogUtilDropTable extends

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-14 Thread via GitHub
dramaticlly commented on code in PR #9305: URL: https://github.com/apache/iceberg/pull/9305#discussion_r1427226753 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -100,7 +100,7 @@ public static void dropTableData(FileIO io, TableMetadata metadata) {

Re: [PR] Core: remove statistic files in CatalogUtil:dropTableData [iceberg]

2023-12-14 Thread via GitHub
RussellSpitzer commented on code in PR #9305: URL: https://github.com/apache/iceberg/pull/9305#discussion_r1427225369 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -100,7 +100,7 @@ public static void dropTableData(FileIO io, TableMetadata metadata) {