Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435550532 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524447 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524541 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524317 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524104 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867984456 Addressed Following review comments - Using static imports - Removing redundant newline - Using Assumptions from Assertj library -- This is an automated message from the

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435274336 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -121,166 +126,194 @@ public void testDropNonEmptyNamespace() {

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435274208 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,88 +29,93 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435274057 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,88 +29,93 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435193321 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -121,166 +126,194 @@ public void testDropNonEmptyNamespace() { sql(

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435192434 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -121,166 +126,194 @@ public void testDropNonEmptyNamespace() { sql(

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435192186 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -121,166 +126,194 @@ public void testDropNonEmptyNamespace() { sql(

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435191708 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,88 +29,93 @@ import org.apache.iceberg.catalog.TableIdentifier; im

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435191020 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,88 +29,93 @@ import org.apache.iceberg.catalog.TableIdentifier; im

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435190729 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,88 +29,93 @@ import org.apache.iceberg.catalog.TableIdentifier; im

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867821695 Thanks for the review, @nastra I have added following changes - Rename FlinkCatalogTestBaseJU5 to CatalogTestBase - Added Junit5 testcase and AssertJ style for TestFlinkCatal

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867717673 > I tested this implementation with couple of subclasses and it seems to be working fine. The difference that I observed here as compared to junit4 in terms of test execution. First test i

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867701145 > can you also please convert `TestMetadataTableReadableMetrics` to JUnit5 and use `CatalogTestBase` as its new base class? ack -- This is an automated message from the Apache

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435062930 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBaseJU5.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867698318 I tested this implementation with couple of subclasses and it seems to be working fine. The difference that I observed here as compared to junit4 in terms of test execution. First test

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1867693190 can you also please convert `TestMetadataTableReadableMetrics` to JUnit5 and use `CatalogTestBase` as its new base class? -- This is an automated message from the Apache Git Service. To

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435056808 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBaseJU5.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

vinitpatni opened a new pull request, #9364: URL: https://github.com/apache/iceberg/pull/9364 Base class creation of FlinkCatalogTestBase for the migration to JUnit5 in regards to https://github.com/apache/iceberg/issues/9079 -- This is an automated message from the Apache Git Service. To