cgpoh commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1825619226
Thanks! Will create the PR later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pvary commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1825287747
Thanks for your work @cgpoh and @nastra for the review!
@cgpoh: Please create the backport PR to v1.15, v1.16. It could be one PR,
and please make sure that the resulting code is the
nastra merged PR #9120:
URL: https://github.com/apache/iceberg/pull/9120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1403236720
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402840153
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402840153
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402326168
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
cgpoh commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1822599964
@pvary will do. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pvary commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1822550315
@cgpoh: Please run `./gradlew spotlessApply` before pushing the changes to
fix splotless errors and minimally `./gradlew build -x test -x javadoc -x
integrationTest` to catch checkstyle err
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1401434184
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestCatalogTblLoader.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1401413672
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/FlinkTestBaseUtils.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
nastra commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400963691
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
nastra commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400963691
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
nastra commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400961872
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/FlinkTestBaseUtils.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400960758
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestCatalogTblLoader.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400859332
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/FlinkTestBaseUtils.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400851908
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestCatalogTblLoader.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1400850567
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestCatalogTblLoader.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cgpoh commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1820796937
@pvary , thanks! Will update the class name and revert the changes for Flink
1.15 and 1.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
pvary commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1820705097
@cgpoh: We usually only create a PR for a single version of Flink (latest).
After that PR is merged, then we create a backport PR to get the changes to the
older versions. This helps the re
20 matches
Mail list logo
