nastra merged PR #9129:
URL: https://github.com/apache/iceberg/pull/9129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
tomtongue commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404151629
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java:
##
@@ -55,12 +55,15 @@ private Object[] toJava(Row row) {
protected void ass
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1825406804
Thanks for the review again. Change the tests that are commented here. I
reviewed all my changes on my end again, but If there're any part that should
be changed, please let me know @na
tomtongue commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404014878
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##
@@ -190,9 +189,9 @@ private void
checkDataFileGroupWithTooMuchData(
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404012356
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##
@@ -190,9 +189,9 @@ private void
checkDataFileGroupWithTooMuchData(Siz
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404011983
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##
@@ -110,9 +109,9 @@ private void
checkDataFileSizeFiltering(SizeBasedD
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404011633
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##
@@ -110,9 +109,9 @@ private void
checkDataFileSizeFiltering(SizeBasedD
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404011518
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##
@@ -129,9 +128,9 @@ private void
checkDataFilesDeleteThreshold(SizeBas
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404010724
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java:
##
@@ -69,19 +72,25 @@ protected void assertEquals(
}
protected void assertE
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404010177
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java:
##
@@ -55,12 +55,15 @@ private Object[] toJava(Row row) {
protected void assert
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404009911
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java:
##
@@ -55,12 +55,15 @@ private Object[] toJava(Row row) {
protected void assert
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1824673027
Thanks for the review, @nastra! I add the following changes based on the
reviews:
* Change `SparkTestHelperBase` with the AssertJ style (removed
`TestHelperBase`)
* Switch `TestSp
tomtongue commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403559874
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestHelperBase.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
tomtongue commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403559874
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestHelperBase.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nastra commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1823947363
> Add the following classes that basically cover JUnit5 and AssertJ styles.
Each class has a lot of inheritants so that new classes are created for now.
And, can I update existing Spark te
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403014630
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403012486
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403012159
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403010787
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBase.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403010020
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestHelperBase.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1823273318
Add the following classes that basically cover JUnit5 and AssertJ styles.
Each class has a lot of inheritants so that new classes are created for now.
@nastra
--
This is an automate
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1822698391
Thank you! I'm working on changes. Let me do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nastra commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1822596157
@tomtongue I think we first need to have a JUnit5 equivalent of
`SparkTestBase` and `SparkTestBaseWithCatalog` before we can migrate
`SparkCatalogTestBase`
--
This is an automated messa
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1401906293
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogTestBaseForJU5.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1822339977
Working on updating other tests for JUnit5 and AssertJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tomtongue opened a new pull request, #9129:
URL: https://github.com/apache/iceberg/pull/9129
Base class creation for the migration to JUnit5 in regards to #9076 . Let me
update other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
26 matches
Mail list logo
