Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

jbonofre commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1673893448 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

jbonofre commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1673893448 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

ajantha-bhat commented on PR #10603: URL: https://github.com/apache/iceberg/pull/10603#issuecomment-091990 I have added 1.6.0 milestone for this now because we still have a day or two for the release cut and we have mentioned that we are deprecating it in 1.6.0 in the PR changes. --

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

danielcweeks commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672685347 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

dimas-b commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672643927 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,22 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

snazy commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672615346 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,22 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

nastra commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672602317 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,22 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

snazy commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672563969 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

danielcweeks commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1672495788 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

danielcweeks commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1671331206 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

Fokko commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1670447305 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

Fokko commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1670447305 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

snazy commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1670212379 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 flow +

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

danielcweeks commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1669603688 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

jackye1995 commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1669533209 ## open-api/rest-catalog-open-api.yaml: ## @@ -134,9 +134,17 @@ paths: post: tags: - OAuth2 API - summary: Get a token using an OAuth2 fl

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

snazy commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1665623076 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -176,19 +176,34 @@ public void initialize(String name, Map unresolved) { long startTi

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

jackye1995 commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1662916466 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -176,19 +176,34 @@ public void initialize(String name, Map unresolved) { long st

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

snazy commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1661024615 ## core/src/test/resources/logback-test.xml: ## @@ -0,0 +1,32 @@ + + + Review Comment: It's required to at least manually verify that the change emits the expected

Re: [PR] Deprecate `oauth/tokens` endpoint [iceberg]

nastra commented on code in PR #10603: URL: https://github.com/apache/iceberg/pull/10603#discussion_r1661022787 ## core/src/test/resources/logback-test.xml: ## @@ -0,0 +1,32 @@ + + + Review Comment: introducing this file and adding the logback dependency doesn't seem related