Re: [PR] Feat: Normalize TableMetadata [iceberg-rust]

2024-09-09 Thread via GitHub
Xuanwo merged PR #611: URL: https://github.com/apache/iceberg-rust/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Feat: Normalize TableMetadata [iceberg-rust]

2024-09-09 Thread via GitHub
c-thiel commented on PR #611: URL: https://github.com/apache/iceberg-rust/pull/611#issuecomment-2337827094 > Thank you very much for working on this. I have a few style suggestions, but please feel free to disregard them if they don't suit you. Thanks @Xuanwo, they all make sense! Add

Re: [PR] Feat: Normalize TableMetadata [iceberg-rust]

2024-09-08 Thread via GitHub
Xuanwo commented on code in PR #611: URL: https://github.com/apache/iceberg-rust/pull/611#discussion_r1749292893 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -278,6 +330,229 @@ impl TableMetadata { self.snapshots .insert(snapshot.snapshot_id(), Arc::