Re: [PR] Glue catalog commit table [iceberg-python]

Fokko commented on PR #140: URL: https://github.com/apache/iceberg-python/pull/140#issuecomment-1873429589 Thanks @HonahX for working on this, and thanks @pdames, @nicor88, and @jackye1995 for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Glue catalog commit table [iceberg-python]

Fokko merged PR #140: URL: https://github.com/apache/iceberg-python/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Glue catalog commit table [iceberg-python]

HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1438999074 ## tests/conftest.py: ## @@ -1586,7 +1586,7 @@ def fixture_aws_credentials() -> Generator[None, None, None]: os.environ.pop("AWS_DEFAULT_REGION") -MOTO_SE

Re: [PR] Glue catalog commit table [iceberg-python]

HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1438987608 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

pdames commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1436639053 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

pdames commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1436629843 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

pdames commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1436629843 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

pdames commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1436629843 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

pdames commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1436629843 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,34 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile.tab

Re: [PR] Glue catalog commit table [iceberg-python]

HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1434657980 ## pyiceberg/catalog/__init__.py: ## @@ -74,6 +75,8 @@ LOCATION = "location" EXTERNAL_TABLE = "EXTERNAL_TABLE" +TABLE_METADATA_FILE_NAME_REGEX = re.compile(r"""

Re: [PR] Glue catalog commit table [iceberg-python]

Fokko commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1433985055 ## pyiceberg/catalog/__init__.py: ## @@ -74,6 +75,8 @@ LOCATION = "location" EXTERNAL_TABLE = "EXTERNAL_TABLE" +TABLE_METADATA_FILE_NAME_REGEX = re.compile(r"""\

Re: [PR] Glue catalog commit table [iceberg-python]

jackye1995 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1431672549 ## pyiceberg/catalog/__init__.py: ## @@ -587,8 +590,32 @@ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path: str) -> ToOutputFile

Re: [PR] Glue catalog commit table [iceberg-python]

HonahX commented on PR #140: URL: https://github.com/apache/iceberg-python/pull/140#issuecomment-1858679351 Thanks @nicor88 and @jackye1995 for the initial review. I think this PR is ready to be reviewed. cc: @Fokko @pdames @svdimchenko -- This is an automated message from the Apac