ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1448763957
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier or
ajantha-bhat commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887024697
PR title may need update as it is TException now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
ajantha-bhat commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887023716
LGTM aswell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
pvary commented on PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#issuecomment-1887018214
@ajantha-bhat: I think this looks good. Any more comments on your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1447431727
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1447431727
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
nk1506 commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1446962785
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier original
ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1446913962
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier or
ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1446913646
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier or
ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1446912565
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier or
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445940972
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
nk1506 commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445921148
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(
nk1506 commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445913794
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445810556
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
nk1506 commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445621596
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1444994303
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
nk1506 commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1444377366
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(
pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1444331653
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(S
nk1506 opened a new pull request, #9432:
URL: https://github.com/apache/iceberg/pull/9432
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
19 matches
Mail list logo