zeroshade commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1760197376
##
catalog/rest.go:
##
@@ -546,12 +640,8 @@ func (r *RestCatalog) ListTables(ctx context.Context,
namespace table.Identifier
path := []string{"namespaces",
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754973597
##
table/metadata.go:
##
@@ -370,26 +876,26 @@ func (c *commonMetadata) validate() error {
func (c *commonMetadata) Version() int { return c.FormatVersion }
-type
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754963661
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754962455
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754957335
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754951127
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754949535
##
partitions.go:
##
@@ -117,6 +117,10 @@ func (ps PartitionSpec) Equals(other PartitionSpec) bool {
return ps.id == other.id && slices.Equal(ps.fields, other.f
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754883143
##
catalog/catalog.go:
##
@@ -146,9 +147,9 @@ type Catalog interface {
// identifiers containing the information required to load the table
via that catalog.
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754878148
##
catalog/catalog.go:
##
@@ -146,9 +147,9 @@ type Catalog interface {
// identifiers containing the information required to load the table
via that catalog.
jwtryg opened a new pull request, #146:
URL: https://github.com/apache/iceberg-go/pull/146
Hi @zeroshade
I think it's really cool that you are working on a golang-iceberg
implementation, and I would like to contribute if I can.
I have tried to finish the rest catalog implementatio
10 matches
Mail list logo
