liurenjie1024 commented on PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#issuecomment-2078666082
Thanks @sdd for this pr, and @Xuanwo @marvinlanhenke for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
liurenjie1024 merged PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
liurenjie1024 commented on PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#issuecomment-2078490131
Let's wait a moment to see if others have comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liurenjie1024 commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580334216
##
crates/iceberg/src/scan.rs:
##
@@ -158,8 +196,24 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580049448
##
crates/iceberg/src/scan.rs:
##
@@ -158,8 +196,24 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut entries =
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580039092
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +240,25 @@ impl TableScan {
.boxed())
}
+fn create_manifest_evaluator(
+id: i32,
+
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1580038792
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +240,25 @@ impl TableScan {
.boxed())
}
+fn create_manifest_evaluator(
+id: i32,
+
liurenjie1024 commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1579248989
##
crates/iceberg/src/scan.rs:
##
@@ -158,8 +196,24 @@ impl TableScan {
.await?;
// Generate data file stream
-let mut
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1578902001
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+id: ,
+
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1577443557
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
Review Comment:
Aah yes,
liurenjie1024 commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1576369286
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1572787996
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+id: ,
+
marvinlanhenke commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1572785208
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+
sdd commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1572771120
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+id: ,
+
marvinlanhenke commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1572233768
##
crates/iceberg/src/scan.rs:
##
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+fn create_manifest_eval_factory(
+//,
+
sdd opened a new pull request, #323:
URL: https://github.com/apache/iceberg-rust/pull/323
This PR was broken out of https://github.com/apache/iceberg-rust/pull/241 as
that PR was getting too large.
It depends on https://github.com/apache/iceberg-rust/pull/322, and
integrates the
16 matches
Mail list logo
