tomtongue commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2084939590
@nastra Thank you! Yes, there are still some test classes to be migrated in
`sink` and `source`, and two files (`HadoopCatalogResource` and
`SimpleDataUtil`) in `flink` package. Will
nastra merged PR #10232:
URL: https://github.com/apache/iceberg/pull/10232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2084737589
@tomtongue let's just add them as part of this PR as I'm assuming the
changes across Flink versions should be identical
--
This is an automated message from the Apache Git Service.
To
tomtongue commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2084694272
@nastra Along with the reflection of your comment, add
`TestFlinkSourceConfig` and its parent test class `TestFlinkTableSource` only
for Flink v1.19. I will create a backport PR for o
tomtongue commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2083084976
Thanks for the review. Sure, will add the changes for
`TestFlinkSourceConfig` and removing the testbase.
--
This is an automated message from the Apache Git Service.
To respond to t
nastra commented on code in PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#discussion_r1582655786
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java:
##
@@ -32,33 +37,37 @@
import org.apache.hadoop.conf.Configuration;
import org
nastra commented on code in PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#discussion_r1582655185
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##
@@ -37,23 +43,22 @@
import org.apache.iceberg.relocated.com.google.common.coll
tomtongue commented on PR #10232:
URL: https://github.com/apache/iceberg/pull/10232#issuecomment-2081755863
@nastra when you have a chance, could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
