Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-07-02 Thread via GitHub
tomtongue commented on PR #10358: URL: https://github.com/apache/iceberg/pull/10358#issuecomment-2200143056 Thank you! Yes, I will submit the backport PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-07-02 Thread via GitHub
nastra merged PR #10358: URL: https://github.com/apache/iceberg/pull/10358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10358: URL: https://github.com/apache/iceberg/pull/10358#discussion_r1624376948 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/reader/ReaderUtil.java: ## @@ -122,4 +123,24 @@ public static CombinedScanTask createCombinedScanTas

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10358: URL: https://github.com/apache/iceberg/pull/10358#discussion_r1624374238 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterExtension.java: ## @@ -50,4 +51,17 @@ public static MiniClusterExtension createWithClasslo

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10358: URL: https://github.com/apache/iceberg/pull/10358#discussion_r1624356950 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java: ## @@ -18,85 +18,53 @@ */ package org.apache.iceberg.flink.sink; +im

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10358: URL: https://github.com/apache/iceberg/pull/10358#discussion_r1624356950 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java: ## @@ -18,85 +18,53 @@ */ package org.apache.iceberg.flink.sink; +im

Re: [PR] Migrate HadoopCatalog related tests in Flink [iceberg]

2024-05-21 Thread via GitHub
tomtongue commented on PR #10358: URL: https://github.com/apache/iceberg/pull/10358#issuecomment-2123786092 @nastra Sorry for the delay. Could you review this PR when you have time? If it's fine, I will add another versions to this PR. -- This is an automated message from the Apache Git S