tomtongue commented on PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#issuecomment-2019566883
@nastra Could you review this PR when you have a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
nastra commented on PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#issuecomment-2019840452
@tomtongue can you also please include the other files from `core` that I
mentioned in
https://github.com/apache/iceberg/pull/10027#issuecomment-2017686753?
--
This is an automated me
nastra commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1538809529
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
nastra commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1538812486
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
tomtongue commented on PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#issuecomment-2019863607
> @tomtongue can you also please include the other files from `core` that I
mentioned in [#10027
(comment)](https://github.com/apache/iceberg/pull/10027#issuecomment-2017686753)?
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1538832259
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1538832259
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
nastra commented on PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#issuecomment-2019975423
yes please add all of these files as part of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nastra commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1538910684
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1539738138
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1539796974
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1539799719
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#issuecomment-2021930566
@nastra Additional classes are migrated. Could you review them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
nastra commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1541315898
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1542341876
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1542341876
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1542341876
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
nastra commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1542721949
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1542761452
##
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##
@@ -766,24 +771,25 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount,
nastra merged PR #10039:
URL: https://github.com/apache/iceberg/pull/10039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
20 matches
Mail list logo