nastra merged PR #9459:
URL: https://github.com/apache/iceberg/pull/9459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
ajantha-bhat commented on PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#issuecomment-1893118053
> I think it would be good to add some tests around this (especially with an
invalid URI). Additionally, it would be good to configure both the
client-api-version and a URI with v1/v
ajantha-bhat commented on code in PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#discussion_r1452954586
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieCatalog.java:
##
@@ -122,9 +119,7 @@ private NessieCatalog initNessieCatalog(String ref) {
ajantha-bhat commented on code in PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#discussion_r1449688656
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -128,6 +133,26 @@ public void initialize(String name, Map
options) {
catalogO
dimas-b commented on code in PR #9459:
URL: https://github.com/apache/iceberg/pull/9459#discussion_r1448996985
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##
@@ -128,6 +133,26 @@ public void initialize(String name, Map
options) {
catalogOption
ajantha-bhat opened a new pull request, #9459:
URL: https://github.com/apache/iceberg/pull/9459
Currently default version is v1.
So, If users need V2, they need to configure v2 URI and set the
`client-api-version` to "2".
With this change, just configuring v2 URI is enough.
`
