Fokko commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1822991443
Thanks @fqaiser94 for the PR, and @liurenjie1024 & @Xuanwo for the review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Fokko merged PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
liurenjie1024 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1822159410
cc @Fokko Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
liurenjie1024 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818822751
The failure is caused by upgrades of `uuid`. You can solve it by fixing
version as [this commit]()
--
This is an automated message from the Apache Git Service.
To respond to the
Fokko commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818816616
Looks like we have a sad clippy:
```
```
error: argument to `panic!()` in a const context must have type `&str`
--> crates/catalog/rest/src/catalog.rs:985:13
|
985 |
liurenjie1024 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818192533
> Is there anything else I need to do to get this merged in?
>
> I don't (understandably) have permissions to merge this myself. https://user-images.githubusercontent.com/2050
fqaiser94 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818190059
Is there anything else I need to do to get this merged in?
I don't (understandably) have permissions to merge this myself.
https://github.com/apache/iceberg-rust/assets/20507
fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1396541554
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -768,7 +769,7 @@ pub struct SnapshotLog {
/// Id of the snapshot.
pub snapshot_id: i64,
/// Last u
fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1396541293
##
crates/iceberg/src/spec/timestamp_millis.rs:
##
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
Xuanwo commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1393652782
##
crates/iceberg/src/spec/timestamp_millis.rs:
##
Review Comment:
By the way, do we need a new type? How about just returning `DateTime`?
--
This is an automa
liurenjie1024 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1393639699
##
crates/iceberg/src/spec/snapshot.rs:
##
@@ -153,7 +155,7 @@ pub(super) mod _serde {
#[serde(skip_serializing_if = "Option::is_none")]
pub pa
fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1393512136
##
crates/iceberg/src/spec/snapshot.rs:
##
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, use
fqaiser94 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1809425134
Moving back to draft while i address comments. Will ping when it's ready
again, shouldn't take too long!
--
This is an automated message from the Apache Git Service.
To respond to t
liurenjie1024 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1390573721
##
crates/iceberg/src/spec/snapshot.rs:
##
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created,
Xuanwo commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1390182259
##
crates/iceberg/src/spec/snapshot.rs:
##
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, used f
Xuanwo commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1390182259
##
crates/iceberg/src/spec/snapshot.rs:
##
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, used f
my-vegetable-has-exploded commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1806753936
Since there is
[timestamptz](https://github.com/apache/iceberg-rust/blob/e26bda3fc2f6df7dde49a6cf7a5f3faafe49313b/crates/iceberg/src/spec/values.rs#L982C4-L982C4)
which
17 matches
Mail list logo
