nastra merged PR #9342:
URL: https://github.com/apache/iceberg/pull/9342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
chinmay-bhat commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1434929879
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestWriteMetricsConfig.java:
##
@@ -271,28 +271,30 @@ public void testCustomMetricCollectionForNe
nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1434921722
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestWriteMetricsConfig.java:
##
@@ -271,28 +271,30 @@ public void testCustomMetricCollectionForNestedPa
chinmay-bhat commented on PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#issuecomment-1867476496
done!
Also, I added the parameterized annotations to `CatalogTestBase`, since
`SparkCatalogTestBase` was parameterized but `CatalogTestBase` was surprisingly
not.
--
This i
nastra commented on PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#issuecomment-1867460904
yes you need a rebase + force push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
chinmay-bhat commented on PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#issuecomment-1867367623
hmm it seems like even after we merged #9341 into main, Github doesn't
recognise and ignore the changes in this PR that now exist in main. Do you
recommend that I rebase onto main an
chinmay-bhat commented on PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#issuecomment-1867295814
Since this PR depends on #9341, I added a patch of files changed in #9341.
Commit
[4f88900](https://github.com/apache/iceberg/pull/9342/commits/4f8890089b77a17987811e14e8659a43fac465
