Fokko commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1579083787
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary,
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary,
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1527602013
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary,
Fokko commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1524545642
##
pyiceberg/catalog/__init__.py:
##
@@ -710,6 +760,45 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1972462085
Now with Sort Order and Partition Spec updates, this PR has all the
necessary pieces for create-replace table operation and is ready for review.
@Fokko @syun64
--
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1496863736
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493065425
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1949447704
Thank you @Fokko for taking time to explain in such great detail. Now it
makes much more sense to have this part of the Catalog API. Made changes as
suggested.
--
This is an
syun64 commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493052840
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return
anupam-saini commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1493051291
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return
Fokko commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1948180604
@anupam-saini Thanks for working on this. I'm not sure if the following API
is where people would expect it:
```python
with table.transaction() as transaction:
syun64 commented on code in PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#discussion_r1491658399
##
pyiceberg/schema.py:
##
@@ -1213,34 +1213,50 @@ def build_position_accessors(schema_or_type:
Union[Schema, IcebergType]) -> Dict
return
anupam-saini opened a new pull request, #433:
URL: https://github.com/apache/iceberg-python/pull/433
Closes #281
Proposed API:
```
with table.transaction() as transaction:
transaction.replace_table_with(new_table)
```
TODO:
- [ ] Update schema
- [ ] Update
14 matches
Mail list logo
