Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1493075652 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -105,6 +105,8 @@ enum HTTPMethod { enum Route { TOKENS(HTTPMethod.POST,

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1493066567 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -204,17 +204,28 @@ private static void throwFailure( throw new RESTException("Unhandled

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1493063230 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -361,6 +392,23 @@ public static class AuthSession { private final String

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

mrcnc commented on PR #8976: URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1947419714 LGTM - Thanks for adding this! I look forward to using it  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1480763887 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a token

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

flyrain commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1480763167 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1480757774 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a token

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

flyrain commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1480395309 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1477366640 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -361,6 +392,23 @@ public static class AuthSession { private final String credential;

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473467310 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -105,6 +105,8 @@ enum HTTPMethod { enum Route { TOKENS(HTTPMethod.POST,

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473325248 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -105,6 +105,8 @@ enum HTTPMethod { enum Route { TOKENS(HTTPMethod.POST,

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473314309 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -314,7 +323,7 @@ private T execute( @Override public void head(String path, Map

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473311127 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -217,22 +230,22 @@ private URI buildUri(String path, Map params) { */ private T

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473308176 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -186,8 +186,21 @@ private static void throwFailure( throw new RESTException("Unhandled

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473296167 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -361,6 +392,23 @@ public static class AuthSession { private final String

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

danielcweeks commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473292686 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on PR #8976: URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1835901741 Leaving a comment to keep the PR active - @nastra @danielcweeks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on PR #8976: URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1819503960 Incorporated suggested changes @nastra . Thank you for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1397367899 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -370,7 +369,7 @@ public void testCatalogCredential() { Mockito.verify(adapter)

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

nastra commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1397361694 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -370,7 +369,7 @@ public void testCatalogCredential() { Mockito.verify(adapter)

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on PR #8976: URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1814980948 Took your suggestions @nastra . I've added the supporting documentation to the OpenAPI spec in this [PR](https://github.com/apache/iceberg/pull/8998) to follow up on the discussion on the

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1395969409 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -186,8 +186,21 @@ private static void throwFailure( throw new RESTException("Unhandled error:

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

nastra commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1385087168 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -186,8 +186,21 @@ private static void throwFailure( throw new RESTException("Unhandled error:

Re: [PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

nastra commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1385056741 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a token

[PR] Support usage of Separate OIDC Authorization Server URI [iceberg]

syun64 opened a new pull request, #8976: URL: https://github.com/apache/iceberg/pull/8976 Related: https://github.com/apache/iceberg/issues/8869 Introduce `OAuth2Properties.TOKEN_URI = "token-uri"` that can be used to override the default behavior that assumes that the Rest Catalog