HeartLinked commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3269099189
> Thanks @HeartLinked for the manual testing! I just checked related Github
actions https://github.com/HeartLinked/iceberg-cpp/actions/runs/17546168928 and
it looks good.
>
>
HeartLinked commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3265577429
@Fokko @raulcd @wgtmac
I'm glad to tell you I've thoroughly tested the updated release scripts and
the supporting GitHub workflow. To do this, I simulated the entire release
pro
HeartLinked commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3269706747
@wgtmac I've fixed these comments.Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Fokko commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3271725839
Let's move this forward, thanks @HeartLinked for working on this, and thanks
@wgtmac, @raulcd and @zhjwpku for the review 💪
--
This is an automated message from the Apache Git Service.
Fokko merged PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
wgtmac commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2332377139
##
.github/workflows/rc.yml:
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOT
wgtmac commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2332425559
##
dev/release/README.md:
##
@@ -0,0 +1,110 @@
+
+
+# Release
+
+## Overview
+
+1. Test the revision to be released
+2. Prepare RC and vote (detailed later)
+
wgtmac commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3266675893
Thanks @HeartLinked for the manual testing! I just checked related Github
actions https://github.com/HeartLinked/iceberg-cpp/actions/runs/17546168928 and
it looks good.
An issue i
wgtmac commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3257641911
@Fokko Thanks for the review! We will try to go through the entire process
on our end to make sure there is no surprise before merging and releasing the
initial version.
--
This is an
wgtmac commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2324431324
##
dev/release/release.sh:
##
@@ -0,0 +1,126 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
Fokko commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2319983730
##
.github/workflows/rc.yml:
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
HeartLinked commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3252107814
@Fokko Thanks! All nits addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Fokko commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2319988975
##
dev/release/README.md:
##
@@ -0,0 +1,103 @@
+
+
+# Release
+
+## Overview
+
+1. Test the revision to be released
+2. Prepare RC and vote (detailed later)
+
Fokko commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2319983226
##
.github/workflows/rc.yml:
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
Fokko commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2320002599
##
dev/release/rat_exclude_files.txt:
##
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
HeartLinked commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3248623800
@raulcd I've added a draft email for annou...@apache.org at `release.sh`.
Thanks for your advice. In the future, maybe after we upload the release to
platforms like Conan Center(#18
raulcd commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3248496606
> @raulcd I'm not sure why my announcement email for parquet release always
gets rejected by it :/
I remember I had a lot of problems configuring my email so they didn't get
rejec
wgtmac commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3248435246
@raulcd I'm not sure why my announcement email for parquet release always
gets rejected by it :/
--
This is an automated message from the Apache Git Service.
To respond to the message,
HeartLinked commented on code in PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2315137488
##
.github/workflows/rc.yml:
##
@@ -0,0 +1,144 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See th
wgtmac commented on PR #193:
URL: https://github.com/apache/iceberg-cpp/pull/193#issuecomment-3247549086
@Fokko @raulcd @zeroshade Do you have more comment on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
20 matches
Mail list logo
