Re: [PR] docs: Add links checker [iceberg]

2024-06-01 Thread via GitHub
manuzhang commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2143503093 I back-ported the fix to 1.5.x releases in #10411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] docs: Add links checker [iceberg]

2024-05-07 Thread via GitHub
manuzhang commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2099520743 @nastra and @print-sid8 These are known issues for previous versions. I'm a bit surprised it's not fixed in 1.5.1 which was just released. -- This is an automated message from the Apa

Re: [PR] docs: Add links checker [iceberg]

2024-05-07 Thread via GitHub
nastra commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2098413421 @bitsondatadev could you take a look at the issue that @print-sid8 reported please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] docs: Add links checker [iceberg]

2024-05-07 Thread via GitHub
print-sid8 commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2097911026 Hi guys, Just reporting something I have noticed in the docs website of Iceberg for versions 1.5.0 and 1.5.1 and also the 'latest' section Lets say I go to - https://i

Re: [PR] docs: Add links checker [iceberg]

2024-03-24 Thread via GitHub
manuzhang commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2016818211 Will this fix get deployed to docs site immediately? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] docs: Add links checker [iceberg]

2024-03-23 Thread via GitHub
Fokko commented on PR #9965: URL: https://github.com/apache/iceberg/pull/9965#issuecomment-2016443994 Thanks for the review @nastra and @manuzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] docs: Add links checker [iceberg]

2024-03-23 Thread via GitHub
Fokko merged PR #9965: URL: https://github.com/apache/iceberg/pull/9965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] docs: Add links checker [iceberg]

2024-03-22 Thread via GitHub
Fokko commented on code in PR #9965: URL: https://github.com/apache/iceberg/pull/9965#discussion_r1535464835 ## .github/workflows/docs-check-links.yml: ## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] docs: Add links checker [iceberg]

2024-03-22 Thread via GitHub
Fokko commented on code in PR #9965: URL: https://github.com/apache/iceberg/pull/9965#discussion_r1535464349 ## format/spec.md: ## @@ -57,6 +57,7 @@ In addition to row-level deletes, version 2 makes some requirements stricter for ## Overview + Review Comment: That's an

Re: [PR] docs: Add links checker [iceberg]

2024-03-18 Thread via GitHub
manuzhang commented on code in PR #9965: URL: https://github.com/apache/iceberg/pull/9965#discussion_r1528624029 ## .github/workflows/docs-check-links.yml: ## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] docs: Add links checker [iceberg]

2024-03-18 Thread via GitHub
nastra commented on code in PR #9965: URL: https://github.com/apache/iceberg/pull/9965#discussion_r1527998892 ## format/spec.md: ## @@ -57,6 +57,7 @@ In addition to row-level deletes, version 2 makes some requirements stricter for ## Overview + Review Comment: should t

Re: [PR] docs: Add links checker [iceberg]

2024-03-15 Thread via GitHub
Fokko commented on code in PR #9965: URL: https://github.com/apache/iceberg/pull/9965#discussion_r1526846143 ## docs/docs/spark-getting-started.md: ## @@ -35,6 +35,7 @@ spark-shell --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ iceb ``` !!! info + Revi

[PR] docs: Add links checker [iceberg]

2024-03-15 Thread via GitHub
Fokko opened a new pull request, #9965: URL: https://github.com/apache/iceberg/pull/9965 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] docs: Add links checker [iceberg]

2024-03-13 Thread via GitHub
Fokko closed pull request #9951: docs: Add links checker URL: https://github.com/apache/iceberg/pull/9951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] docs: Add links checker [iceberg]

2024-03-13 Thread via GitHub
Fokko closed pull request #9951: docs: Add links checker URL: https://github.com/apache/iceberg/pull/9951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] docs: Add links checker [iceberg]

2024-03-13 Thread via GitHub
Fokko opened a new pull request, #9951: URL: https://github.com/apache/iceberg/pull/9951 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail